Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxmox: [draft] Proper check for update_config #8712

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions plugins/modules/proxmox.py
Original file line number Diff line number Diff line change
Expand Up @@ -818,6 +818,10 @@ def build_volume(
if new_value not in current_values:
update_config = True
break
# Check if current values have more elements than requested values
if len(current_values) != len(requested_values):
update_config = True

# if it's not a list (or string) just compare the current value
else:
# some types don't match with the API, so forcing to string for comparison
Expand Down