Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow installation of java11 version of nexus #424

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bgp-sz
Copy link

@bgp-sz bgp-sz commented May 15, 2024

Add optional "nexus_suffix" variable.

Can be set to "java11" to fetch the java11 version instead of the default java8 version starting with 3.76.0

Add optional "nexus_suffix" variable. Can be set to "java11" to fetch the java11 version instead of the default java8 version starting with 3.76.0
@brianveltman
Copy link
Contributor

IMHO #417 has a nicer way of handling java8 and java11 versions.

@bgp-sz
Copy link
Author

bgp-sz commented May 16, 2024

Thanks for the pointer.

I think my way has some upsides as #417 will break downloads for older version (<3.67) and will also likely need further changes in the future.

But as a user either version is fine for me :-)

@gr0l
Copy link

gr0l commented May 28, 2024

Any news on this change?

@uwehdaub
Copy link

From the newly released version 3.71.0 on Nexus will only support Java17 and the H2 DB.
See https://help.sonatype.com/en/download.html

The corresponding download archive of Nexus has the format https://download.sonatype.com/nexus/3/nexus-3.71.0-06-mac.tgz.

This PR can't handle this new situation and needs to be supplemented to work also with the newest Nexus version.

@bgp-sz
Copy link
Author

bgp-sz commented Aug 26, 2024

I would expect setting nexus_suffix to mac should work. Did you try that?

@uwehdaub
Copy link

Hi @bgp-sz
thanks for your response.
My last comment was meant to illustrate the fact, that the java version is now vanished again from the download URL.

@brianveltman
Copy link
Contributor

@bgp-sz that wouldnt work in your code. It would result in the following string:
nexus-3.70.0-mac-unix.tar.gz.

The question is do we want to support this role for macOS targets (and maybe Windows) as well?
I bet there are multiple tasks and modules in this role that would need to be refactored to fully support macOS and/or Windows.

@bgp-sz
Copy link
Author

bgp-sz commented Aug 26, 2024

@bgp-sz that wouldnt work in your code. It would result in the following string: nexus-3.70.0-mac-unix.tar.gz.

You are right, i didn't read it properly. As you mentioned, this role never supported mac, and I think it's a bit out of scope of this PR. You can always not set nexus_suffix to get the old behaviour of no specific package name back, so it should be safe to merge.

@bgp-sz bgp-sz closed this Aug 26, 2024
@bgp-sz bgp-sz reopened this Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants