Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved ayah mode support #103

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

waleedkadous
Copy link
Collaborator

Improved the responses in the case of ayah requests. Added more utilities for evaluation.

@abdullah-alnahas
Copy link
Collaborator

Salam Waleed. A few quick suggestions:

  1. Persona Input: It might be more efficient to pass the persona as an input to the endpoint. We could then consolidate the two prompt files into a single file and dynamically adjust the persona based on the request parameter. This would simplify maintenance, allow us to easily add more personas in the future, and ensure we're always working on improving a single, core prompt.
  2. Context in Prompt: Maybe include the ayah text, surrounding ayat, and perhaps a translation in the prompt for better responses.
  3. Less Apologetic Tone: Could we tweak the prompt to ask the model for a less apologetic tone?
  4. Ruff Errors: Addressing the Ruff errors would help with the CI pipeline.

What do you think? If you like any of these, feel free to take them on, or let's discuss how to split them up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants