Avoid double jamming prove arguments in Anoma CLI commands #3298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulcadman
force-pushed
the
fix-double-encoding
branch
from
7f116b9 to
0bcc72e
Compare
paulcadman
changed the title
bytes and base64 prove arguments
janmasrovira
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way program arguments are processed by the
juvix dev nockma run {with-client, ephemeral-client}andjuvix dev anoma proveCLI commands.Files provided in
--arg 'bytes:..'and--arg 'base64:..'flags are now assumed to be jammed and are not jammed again before they are submitted to the Anoma client.Changes in anoma-apps
The Anoma apps in anoma-apps use the
proveCLI command and so the signatures of theirmainfunctions will change:For example, in HelloWorld.juvix the logic is passed as a jammed noun in an argument to prove.
Previously the argument was jammed again before being sent and so had to be decoded in the
mainfunction before being used (the Anoma client cues (i.e decodes) the argument once before calling the program).After the change in this PR, the logic argument is not jammed again before being sent to the Anoma client and so the signature of the main function should be changed to: