Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message for ambiguous export #3289

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

janmasrovira
Copy link
Collaborator

@janmasrovira janmasrovira commented Jan 20, 2025

The error message now lists all possibilities. It also uses the correct word to describe the namespace.
E.g.
Before

/home/jan/projects/anoma-applib/Applib.juvix:1:8-14: error:
The symbol ExternalIdentity is exported multiple times in the module Applib

After

/home/jan/projects/anoma-applib/Applib.juvix:1:8-14: error:
The module ExternalIdentity is exported multiple times in the module Applib
• Defined in /home/jan/projects/anoma-applib/Applib/Identities.juvix:13:8-24
• Defined in /home/jan/projects/anoma-applib/Anoma/Identity/External.juvix:7:6-22

@janmasrovira janmasrovira added this to the 0.6.10 milestone Jan 20, 2025
@janmasrovira janmasrovira self-assigned this Jan 20, 2025
@janmasrovira janmasrovira force-pushed the improve-multi-export-error-message branch from dc907e0 to be8258a Compare January 20, 2025 18:25
@janmasrovira janmasrovira marked this pull request as ready for review January 20, 2025 18:26
@lukaszcz lukaszcz merged commit e84bace into main Jan 21, 2025
7 of 8 checks passed
@lukaszcz lukaszcz deleted the improve-multi-export-error-message branch January 21, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants