Fix let-patterns inside named arguments #3274
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
impossible
crash #3269NameKind
of a name used as a variable was not properly updated toKNameLocal
, which later caused the identifier to be converted intoIdenFunction
bysubstitutionE
called by the code handling named arguments. The functionsubstitutionE
callstoExpression
on the name instead of on the identifier expression, andtoExpression
called on a name chooses the kind of identifier to create based onNameKind
. In my opinion, it is error-prone to have two distinct places which determine the kind of an identifier. IngenPatternDefs
, I changedIdenFunction
toIdenVar
but forgot about adjustingNameKind
.