Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fragment-Migration] Sync Login Screen to use Fragments instead of activities #17908

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

criticalAY
Copy link
Contributor

@criticalAY criticalAY commented Jan 31, 2025

Purpose / Description

  • Migrates the MyAccount, Login Activities to fragments

Approach

  • Create a new activity to handle the logged in and !LoggedIn situation as we are starting the fragments from preference screen
  • Two different fragments to handle the two situations i.e. Logged in and vice versa
  • Use view model for Login fragment and handles the changes via the viewmodel
  • remove the old code
  • update existing test (one more test file is needed for Logged in UI which I deleted)

How Has This Been Tested?

Test On API 35 Google emulator:
I am uploading all the screenshots and videos to drive as it would be too much for the template

https://drive.google.com/drive/folders/1lYg4rz-SdFhwb-3rlQIs5aUwnjwJgDiK?usp=sharing

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@criticalAY criticalAY force-pushed the frag-migrate-myaccount branch from b5eae91 to 0ac3c3b Compare February 1, 2025 12:17
- enum class LoginError to handle the errors related to Login and LoginState class for various login states
@criticalAY criticalAY force-pushed the frag-migrate-myaccount branch 6 times, most recently from 7306b07 to 25e9a69 Compare February 1, 2025 13:14
@mikehardy
Copy link
Member

Please test locally before pushing

@criticalAY criticalAY force-pushed the frag-migrate-myaccount branch from 25e9a69 to dde04fc Compare February 1, 2025 13:32
Copy link
Member

@BrayanDSO BrayanDSO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How Has This Been Tested?
Test On API 35

Quoting the PR template:

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration (SDK version(s), emulator or physical, etc)

So please do that. Your description isn't enough for anyone to reproduce or trust your testing process. A video would be even better.

AnkiDroid/build.gradle Show resolved Hide resolved
@BrayanDSO BrayanDSO added the Needs Author Reply Waiting for a reply from the original author label Feb 1, 2025
@criticalAY criticalAY force-pushed the frag-migrate-myaccount branch from dde04fc to c36fd3f Compare February 1, 2025 17:54
@criticalAY criticalAY force-pushed the frag-migrate-myaccount branch from c36fd3f to 033deeb Compare February 1, 2025 18:41
@criticalAY
Copy link
Contributor Author

I have uploaded all the SSs to drive along with few test videos

@criticalAY criticalAY added Needs Review and removed Needs Author Reply Waiting for a reply from the original author labels Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants