-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fragment-Migration] Sync Login Screen to use Fragments instead of activities #17908
base: main
Are you sure you want to change the base?
Conversation
b5eae91
to
0ac3c3b
Compare
- enum class LoginError to handle the errors related to Login and LoginState class for various login states
7306b07
to
25e9a69
Compare
Please test locally before pushing |
25e9a69
to
dde04fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How Has This Been Tested?
Test On API 35
Quoting the PR template:
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration (SDK version(s), emulator or physical, etc)
So please do that. Your description isn't enough for anyone to reproduce or trust your testing process. A video would be even better.
dde04fc
to
c36fd3f
Compare
- use the LoginIn view model to handle the logic and UI state
…e of MyAccount activity
- update usage to new LoginFragment
c36fd3f
to
033deeb
Compare
I have uploaded all the SSs to drive along with few test videos |
Purpose / Description
Approach
!LoggedIn
situation as we are starting the fragments from preference screenHow Has This Been Tested?
Test On API 35 Google emulator:
I am uploading all the screenshots and videos to drive as it would be too much for the template
https://drive.google.com/drive/folders/1lYg4rz-SdFhwb-3rlQIs5aUwnjwJgDiK?usp=sharing
Checklist
Please, go through these checks before submitting the PR.