-
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented advanced settings screen (buffering and HTTP settings) #928
base: main
Are you sure you want to change the base?
Conversation
Hey @bitlinker can you fix linting by running the following cmd in terminal |
Done |
Hey @bitlinker, thanks for the pull request. I couldn't play local videos now. I believe it's because we're setting |
Hey @anilbeesetti, sorry I didn't checked the local videos last time. Yes, the issue was with the data source configuration - the I agree, advanced settings is more suitable name here, since buffer configurations are applied to local videos too. Renamed it. |
Fixed ktlint =) |
Hi! Please take a look at this implementation of additional network settings screen. It allows to configure ExoPlayer's streaming buffers size and to add aditional parameters to HTTP requests: User-Agent and other header values (some streaming hosts require specific values)
Also please note the fixes at PlayerViewModel:46 and PlayerViewModel:52. The settings repo is "preheated" here, but it seems not enough: When the player is created PlayerActivity.kt:288, the settings are not available yet and default ones are used! I know that
runBlocking()
is ugly, but can't find better solution here. It shouldn't actually block the thread since the preferences flow should already have value available.