Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] - Background playback #1103

Open
wants to merge 56 commits into
base: main
Choose a base branch
from
Open

[WIP] - Background playback #1103

wants to merge 56 commits into from

Conversation

anilbeesetti
Copy link
Owner

No description provided.

@BierDav
Copy link

BierDav commented Oct 11, 2024

Would love this feature. What is blocking it to get merged?

@anilbeesetti
Copy link
Owner Author

Would love this feature. What is blocking it to get merged?

It's still a work in progress

@anilbeesetti
Copy link
Owner Author

Hey @Pentaphon, @BierDav, @TidalMist, @eight04, and anyone else reading this! The background playback feature is a major update and required a lot of code changes. If you could test it out and share any feedback or edge cases you find, it would be really helpful. Here’s the link to the debug APK: Debug APK. Thanks a lot!

@Pentaphon
Copy link

Pentaphon commented Nov 8, 2024

If you could test it out and share any feedback or edge cases you find,

@anilbeesetti Just tried it and when I press the headphones icon which I assume to be the background playback button, it just highlights the button and the player just waits for me to put the video in the background by pressing back or home, which works, but isn't immediate. We still need the following things:

  1. When you press the background playback button, the player should slide away and go to the notification where only the sound should play, similar to how the player goes to the PIP window when you press the PIP button.
  2. We need an X button to close the notification when we want to close it completely from the notification itself.

Other than those two issues, it is working well. Haven't had enough time to find any playback bugs yet.

@eight04
Copy link

eight04 commented Nov 8, 2024

Tried it and it works 🎉

For the headphone button, I think it can be moved to settings as a checkbox "continue playing in the background". So that when enabled, users can use the power button to turn off/on the monitor while playing the video.

@Pentaphon
Copy link

Pentaphon commented Nov 8, 2024

For the headphone button, I think it can be moved to settings as a checkbox "continue playing in the background"

Or we can have a setting that lets you select 2 options:

Background Playback:

  1. Use Background Playback Button (manual)
  2. Always play video in background unless stopped or paused (auto)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants