-
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] - Background playback #1103
base: main
Are you sure you want to change the base?
Conversation
Would love this feature. What is blocking it to get merged? |
It's still a work in progress |
…nd then foreground
Hey @Pentaphon, @BierDav, @TidalMist, @eight04, and anyone else reading this! The background playback feature is a major update and required a lot of code changes. If you could test it out and share any feedback or edge cases you find, it would be really helpful. Here’s the link to the debug APK: Debug APK. Thanks a lot! |
@anilbeesetti Just tried it and when I press the headphones icon which I assume to be the background playback button, it just highlights the button and the player just waits for me to put the video in the background by pressing back or home, which works, but isn't immediate. We still need the following things:
Other than those two issues, it is working well. Haven't had enough time to find any playback bugs yet. |
Tried it and it works 🎉 For the headphone button, I think it can be moved to settings as a checkbox "continue playing in the background". So that when enabled, users can use the power button to turn off/on the monitor while playing the video. |
Or we can have a setting that lets you select 2 options: Background Playback:
|
No description provided.