🔥Remove static Default getters, obsoleted by UnitsNetSetup

[angularsen]

Ref #1200

Remove static Default getter property for UnitConverter, UnitAbbreviationsCache, QuantityParser, UnitParser. These just pointed to the singleton UnitsNetSetup.Default and were made obsolete in v5.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86%. Comparing base (104c67a) to head (ce11086).
Report is 1 commits behind head on release/v6.

Additional details and impacted files

@@            Coverage Diff             @@
##           release/v6   #1475   +/-   ##
==========================================
  Coverage          86%     86%           
==========================================
  Files             298     298           
  Lines           30520   30516    -4     
==========================================
  Hits            26404   26404           
+ Misses           4116    4112    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[lipchev]

@angularsen Sorry, I've just gotten around to review these recent changes.. I know these had been made [Obsolete] for a while now, but are you sure there is sufficient reason to remove them?

1. As long as the dependency between the types is correct (it is) then there shouldn't be any harm in having them (do you see something I don't?)
2. Even if we instantiate and use the concrete type, it's Default property isn't going to trigger the static constructor on the UnitsNetSetup, unless explicitly accessed
3. I think it's pretty clear that these are simply shortcuts to UnitsNetSetup.Default.XXX - I personally find UnitParser.Default.Parse(..) to be much more intuitive than UnitsNetSetup.Default.UnitParser.Parse(..)

[angularsen]

I had the same thought, I don't have a strong opinion here. My thinking was that it may be better to have a single way to access these things, for docs/sample code and what not, but the syntax becomes more clunky.

The main benefit of moving things into UnitsNetSetup was ensuring the same instance of UnitAbbreviationCache was used, but there is no harm in having these getter properties as convenience.

I'm fine reverting this, but we should then remove the obsolete flags in v5 too.

[angularsen]

Sorry for not waiting for review and rushing a bit, but I have a little bit of extra time in the holidays and just want to get things done 😄 We can always revert, I'm glad to have a pair of extra eyes on these things 🙇

[lipchev]

Well, it was on the wish-list- I hadn't gotten around to arguing against it :)

I wasn't 100% sure whether they are safe in v5 but I was kinda hoping to remove the [Obsolete] tag in v6 (where I'm pretty sure it's all good).

Plus I'm sure there are many holdouts who ignored the [Obsolete] flag :)

[lipchev]

Plus I'm sure there are many holdouts who ignored the [Obsolete] flag :)

Here's one 🤣