refactor: handle case where node is null in Visit function #746
This check has been archived and is scheduled for deletion.
Learn more about checks retention
GitHub Actions / Test - windows Common/tests
failed
Jul 31, 2023 in 1s
Test - windows Common/tests ❌
❌ Common/tests/TestResults/test-results.trx
5643 tests were completed in 117s with 5636 passed, 3 failed and 4 skipped.
| Test suite | Passed | Failed | Skipped | Time |
|---|---|---|---|---|
| ArmoniK.Core.Common.Tests.AdapterLoading.AdapterLoadingTest | 8✅ | 424ms | ||
| ArmoniK.Core.Common.Tests.ApplicationRawTests | 2✅ | 8ms | ||
| ArmoniK.Core.Common.Tests.Auth.AuthenticationCacheTest | 10✅ | 10ms | ||
| ArmoniK.Core.Common.Tests.Auth.AuthenticationIntegrationTest(DefaultAuth) | 962✅ | 3s | ||
| ArmoniK.Core.Common.Tests.Auth.AuthenticationIntegrationTest(NoAuthentication) | 962✅ | 377ms | ||
| ArmoniK.Core.Common.Tests.Auth.AuthenticationIntegrationTest(NoAuthorization) | 962✅ | 408ms | ||
| ArmoniK.Core.Common.Tests.Auth.AuthenticationIntegrationTest(NoImpersonation) | 962✅ | 401ms | ||
| ArmoniK.Core.Common.Tests.Auth.AuthenticationIntegrationTest(NoImpersonationNoAuthorization) | 962✅ | 353ms | ||
| ArmoniK.Core.Common.Tests.Auth.CheckAuthenticationAttributes | 50✅ | 2ms | ||
| ArmoniK.Core.Common.Tests.Auth.PermissionTest | 10✅ | 1⚪ | 306ms | |
| ArmoniK.Core.Common.Tests.FullIntegration.FullyIntegratedTest | 3⚪ | 0ms | ||
| ArmoniK.Core.Common.Tests.GrpcTasksServiceTests | 1✅ | 2s | ||
| ArmoniK.Core.Common.Tests.HealthChecks.HealthCheckTest | 9✅ | 36ms | ||
| ArmoniK.Core.Common.Tests.HealthChecks.HowHealthCheckWorkTest | 2✅ | 164ms | ||
| ArmoniK.Core.Common.Tests.ListApplicationsRequestExt.ToApplicationFieldTest | 5✅ | 2ms | ||
| ArmoniK.Core.Common.Tests.ListApplicationsRequestExt.ToApplicationFilterTest | 12✅ | 6ms | ||
| ArmoniK.Core.Common.Tests.ListPartitionsRequestExt.ToPartitionDataFieldTest | 6✅ | 1ms | ||
| ArmoniK.Core.Common.Tests.ListPartitionsRequestExt.ToPartitionDataFilterTest | 10✅ | 3❌ | 9ms | |
| ArmoniK.Core.Common.Tests.ListResultsRequestExt.ToResultFieldTest | 6✅ | 2ms | ||
| ArmoniK.Core.Common.Tests.ListResultsRequestExt.ToResultFilterTest | 11✅ | 5ms | ||
| ArmoniK.Core.Common.Tests.ListSessionsRequestExt.ToSessionDataFieldTest | 6✅ | 2ms | ||
| ArmoniK.Core.Common.Tests.ListSessionsRequestExt.ToSessionDataFilterTest | 12✅ | 6ms | ||
| ArmoniK.Core.Common.Tests.ListTasksRequestExt.ToTaskDataFieldTest | 28✅ | 9ms | ||
| ArmoniK.Core.Common.Tests.ListTasksRequestExt.ToTaskDataFilterTest | 22✅ | 8ms | ||
| ArmoniK.Core.Common.Tests.LoggerExtTest | 2✅ | 82ms | ||
| ArmoniK.Core.Common.Tests.Pollster.AgentTest | 14✅ | 12s | ||
| ArmoniK.Core.Common.Tests.Pollster.DataPrefetcherTest | 7✅ | 62ms | ||
| ArmoniK.Core.Common.Tests.Pollster.PollsterTest | 11✅ | 20s | ||
| ArmoniK.Core.Common.Tests.Pollster.TaskHandlerTest | 29✅ | 43s | ||
| ArmoniK.Core.Common.Tests.RpcExtTests | 36✅ | 4ms | ||
| ArmoniK.Core.Common.Tests.StateMachines.ComputeRequestStateMachineTest | 14✅ | 39ms | ||
| ArmoniK.Core.Common.Tests.StateMachines.ProcessReplyCreateLargeTaskStateMachineTest | 13✅ | 26ms | ||
| ArmoniK.Core.Common.Tests.StateMachines.ProcessReplyResultStateMachineTest | 10✅ | 22ms | ||
| ArmoniK.Core.Common.Tests.Submitter.ExceptionInterceptorTests | 3✅ | 208ms | ||
| ArmoniK.Core.Common.Tests.Submitter.GrpcSubmitterServiceTests | 48✅ | 92ms | ||
| ArmoniK.Core.Common.Tests.Submitter.IntegrationGrpcSubmitterServiceTest | 97✅ | 744ms | ||
| ArmoniK.Core.Common.Tests.Submitter.SubmitterTests | 15✅ | 13s | ||
| ArmoniK.Core.Common.Tests.TaskFilterExtTests | 14✅ | 49ms | ||
| ArmoniK.Core.Common.Tests.TaskOptionsTests | 2✅ | 1ms | ||
| ArmoniK.Core.Common.Tests.TestBase.AuthenticationTableTestBase | 32✅ | 3ms | ||
| ArmoniK.Core.Common.Tests.TestBase.ObjectStorageTestBase | 7✅ | 6ms | ||
| ArmoniK.Core.Common.Tests.TestBase.PartitionTableTestBase | 22✅ | 6ms | ||
| ArmoniK.Core.Common.Tests.TestBase.QueueStorageTestsBase | 5✅ | 6ms | ||
| ArmoniK.Core.Common.Tests.TestBase.ResultTableTestBase | 30✅ | 16ms | ||
| ArmoniK.Core.Common.Tests.TestBase.ResultWatcherTestBase | 4✅ | 4ms | ||
| ArmoniK.Core.Common.Tests.TestBase.SessionTableTestBase | 18✅ | 9ms | ||
| ArmoniK.Core.Common.Tests.TestBase.TaskTableTestBase | 79✅ | 33ms | ||
| ArmoniK.Core.Common.Tests.TestBase.TaskWatcherTestBase | 3✅ | 3ms | ||
| ArmoniK.Core.Common.Tests.Validators.CancelTasksRequestValidatorTest | 3✅ | 1ms | ||
| ArmoniK.Core.Common.Tests.Validators.CreateLargeTaskRequestValidatorTest | 9✅ | 27ms | ||
| ArmoniK.Core.Common.Tests.Validators.CreateSessionRequestValidatorTest | 4✅ | 1ms | ||
| ArmoniK.Core.Common.Tests.Validators.CreateSmallTaskRequestValidatorTest | 16✅ | 4ms | ||
| ArmoniK.Core.Common.Tests.Validators.ListApplicationsRequestValidatorTest | 8✅ | 10ms | ||
| ArmoniK.Core.Common.Tests.Validators.ListPartitionsRequestValidatorTest | 8✅ | 2ms | ||
| ArmoniK.Core.Common.Tests.Validators.ListResultsRequestValidatorTest | 8✅ | 2ms | ||
| ArmoniK.Core.Common.Tests.Validators.ListSessionsRequestValidatorTest | 8✅ | 2ms | ||
| ArmoniK.Core.Common.Tests.Validators.ListTasksRequestValidatorTest | 8✅ | 9ms | ||
| ArmoniK.Core.Common.Tests.Validators.SessionFilterValidatorTest | 2✅ | 2ms | ||
| ArmoniK.Core.Common.Tests.Validators.TaskFilterValidatorTest | 13✅ | 4ms | ||
| ArmoniK.Core.Common.Tests.Validators.TaskOptionsValidatorTest | 11✅ | 1ms | ||
| ArmoniK.Core.Common.Tests.WatchToGrpcTests | 3✅ | 3s |
❌ ArmoniK.Core.Common.Tests.ListPartitionsRequestExt.ToPartitionDataFilterTest
✅ Filter({ "field": { "partitionRawField": { "field": "PARTITION_RAW_ENUM_FIELD_ID" } }, "filterString": { "value": "PartitionId_false" } })
✅ Filter({ "field": { "partitionRawField": { "field": "PARTITION_RAW_ENUM_FIELD_ID" } }, "filterString": { "value": "PartitionId" } })
❌ Filter({ "field": { "partitionRawField": { "field": "PARTITION_RAW_ENUM_FIELD_PARENT_PARTITION_IDS" } }, "filterArray": { "value": "AnotherParentPartitionId1" } })
System.ArgumentNullException : Value cannot be null. (Parameter 'node')
❌ Filter({ "field": { "partitionRawField": { "field": "PARTITION_RAW_ENUM_FIELD_PARENT_PARTITION_IDS" } }, "filterArray": { "value": "AnotherParentPartitionId1", "operator": "FILTER_ARRAY_OPERATOR_NOT_CONTAINS" } })
System.ArgumentNullException : Value cannot be null. (Parameter 'node')
❌ Filter({ "field": { "partitionRawField": { "field": "PARTITION_RAW_ENUM_FIELD_PARENT_PARTITION_IDS" } }, "filterArray": { "value": "ParentPartitionId1" } })
System.ArgumentNullException : Value cannot be null. (Parameter 'node')
✅ Filter({ "field": { "partitionRawField": { "field": "PARTITION_RAW_ENUM_FIELD_POD_MAX" } }, "filterNumber": { "value": "10" } })
✅ Filter({ "field": { "partitionRawField": { "field": "PARTITION_RAW_ENUM_FIELD_POD_MAX" } }, "filterNumber": { "value": "2" } })
✅ Filter({ "field": { "partitionRawField": { "field": "PARTITION_RAW_ENUM_FIELD_POD_RESERVED" } }, "filterNumber": { "value": "1" } })
✅ Filter({ "field": { "partitionRawField": { "field": "PARTITION_RAW_ENUM_FIELD_POD_RESERVED" } }, "filterNumber": { "value": "2" } })
✅ Filter({ "field": { "partitionRawField": { "field": "PARTITION_RAW_ENUM_FIELD_PREEMPTION_PERCENTAGE" } }, "filterNumber": { "value": "15" } })
✅ Filter({ "field": { "partitionRawField": { "field": "PARTITION_RAW_ENUM_FIELD_PREEMPTION_PERCENTAGE" } }, "filterNumber": { "value": "2" } })
✅ Filter({ "field": { "partitionRawField": { "field": "PARTITION_RAW_ENUM_FIELD_PRIORITY" } }, "filterNumber": { "value": "1" } })
✅ Filter({ "field": { "partitionRawField": { "field": "PARTITION_RAW_ENUM_FIELD_PRIORITY" } }, "filterNumber": { "value": "2" } })
Annotations
Check failure on line 88 in Common/src/gRPC/ExpressionExt.cs
github-actions / Test - windows Common/tests
ArmoniK.Core.Common.Tests.ListPartitionsRequestExt.ToPartitionDataFilterTest ► Filter({ "field": { "partitionRawField": { "field": "PARTITION_RAW_ENUM_FIELD_PARENT_PARTITION_IDS" } }, "filterArray": { "value": "AnotherParentPartitionId1" } })
Failed test found in:
Common/tests/TestResults/test-results.trx
Error:
System.ArgumentNullException : Value cannot be null. (Parameter 'node')
Raw output
System.ArgumentNullException : Value cannot be null. (Parameter 'node')
at ArmoniK.Core.Common.gRPC.ExpressionExt.ReplaceExpressionVisitor.Visit(Expression node) in D:\a\ArmoniK.Core\ArmoniK.Core\Common\src\gRPC\ExpressionExt.cs:line 88
at System.Linq.Expressions.ExpressionVisitor.VisitMethodCall(MethodCallExpression node)
at ArmoniK.Core.Common.gRPC.ExpressionExt.ReplaceExpressionVisitor.Visit(Expression node) in D:\a\ArmoniK.Core\ArmoniK.Core\Common\src\gRPC\ExpressionExt.cs:line 91
at ArmoniK.Core.Common.gRPC.ExpressionExt.MakeBinaryExpression[T](ExpressionType expressionType, Expression`1 expr1, Expression`1 expr2) in D:\a\ArmoniK.Core\ArmoniK.Core\Common\src\gRPC\ExpressionExt.cs:line 37
at ArmoniK.Core.Common.gRPC.ExpressionExt.ExpressionAnd[T](Expression`1 expr1, Expression`1 expr2) in D:\a\ArmoniK.Core\ArmoniK.Core\Common\src\gRPC\ExpressionExt.cs:line 54
at ArmoniK.Core.Common.gRPC.ListPartitionsRequestExt.ToPartitionFilter(Filters filters) in D:\a\ArmoniK.Core\ArmoniK.Core\Common\src\gRPC\ListPartitionsRequestExt.cs:line 96
at ArmoniK.Core.Common.Tests.ListPartitionsRequestExt.ToPartitionDataFilterTest.RequestToFunc(Sort sort, IEnumerable`1 filterFields) in D:\a\ArmoniK.Core\ArmoniK.Core\Common\tests\ListPartitionsRequestExt\ToTaskDataFilterTest.cs:line 62
at ArmoniK.Core.Common.Tests.ListPartitionsRequestExt.ToPartitionDataFilterTest.Filter(IEnumerable`1 filterFields, Boolean expected) in D:\a\ArmoniK.Core\ArmoniK.Core\Common\tests\ListPartitionsRequestExt\ToTaskDataFilterTest.cs:line 73
Check failure on line 88 in Common/src/gRPC/ExpressionExt.cs
github-actions / Test - windows Common/tests
ArmoniK.Core.Common.Tests.ListPartitionsRequestExt.ToPartitionDataFilterTest ► Filter({ "field": { "partitionRawField": { "field": "PARTITION_RAW_ENUM_FIELD_PARENT_PARTITION_IDS" } }, "filterArray": { "value": "AnotherParentPartitionId1", "operator": "...
Failed test found in:
Common/tests/TestResults/test-results.trx
Error:
System.ArgumentNullException : Value cannot be null. (Parameter 'node')
Raw output
System.ArgumentNullException : Value cannot be null. (Parameter 'node')
at ArmoniK.Core.Common.gRPC.ExpressionExt.ReplaceExpressionVisitor.Visit(Expression node) in D:\a\ArmoniK.Core\ArmoniK.Core\Common\src\gRPC\ExpressionExt.cs:line 88
at System.Linq.Expressions.ExpressionVisitor.VisitMethodCall(MethodCallExpression node)
at ArmoniK.Core.Common.gRPC.ExpressionExt.ReplaceExpressionVisitor.Visit(Expression node) in D:\a\ArmoniK.Core\ArmoniK.Core\Common\src\gRPC\ExpressionExt.cs:line 91
at System.Linq.Expressions.ExpressionVisitor.VisitUnary(UnaryExpression node)
at ArmoniK.Core.Common.gRPC.ExpressionExt.ReplaceExpressionVisitor.Visit(Expression node) in D:\a\ArmoniK.Core\ArmoniK.Core\Common\src\gRPC\ExpressionExt.cs:line 91
at ArmoniK.Core.Common.gRPC.ExpressionExt.MakeBinaryExpression[T](ExpressionType expressionType, Expression`1 expr1, Expression`1 expr2) in D:\a\ArmoniK.Core\ArmoniK.Core\Common\src\gRPC\ExpressionExt.cs:line 37
at ArmoniK.Core.Common.gRPC.ExpressionExt.ExpressionAnd[T](Expression`1 expr1, Expression`1 expr2) in D:\a\ArmoniK.Core\ArmoniK.Core\Common\src\gRPC\ExpressionExt.cs:line 54
at ArmoniK.Core.Common.gRPC.ListPartitionsRequestExt.ToPartitionFilter(Filters filters) in D:\a\ArmoniK.Core\ArmoniK.Core\Common\src\gRPC\ListPartitionsRequestExt.cs:line 96
at ArmoniK.Core.Common.Tests.ListPartitionsRequestExt.ToPartitionDataFilterTest.RequestToFunc(Sort sort, IEnumerable`1 filterFields) in D:\a\ArmoniK.Core\ArmoniK.Core\Common\tests\ListPartitionsRequestExt\ToTaskDataFilterTest.cs:line 62
at ArmoniK.Core.Common.Tests.ListPartitionsRequestExt.ToPartitionDataFilterTest.Filter(IEnumerable`1 filterFields, Boolean expected) in D:\a\ArmoniK.Core\ArmoniK.Core\Common\tests\ListPartitionsRequestExt\ToTaskDataFilterTest.cs:line 73
Check failure on line 88 in Common/src/gRPC/ExpressionExt.cs
github-actions / Test - windows Common/tests
ArmoniK.Core.Common.Tests.ListPartitionsRequestExt.ToPartitionDataFilterTest ► Filter({ "field": { "partitionRawField": { "field": "PARTITION_RAW_ENUM_FIELD_PARENT_PARTITION_IDS" } }, "filterArray": { "value": "ParentPartitionId1" } })
Failed test found in:
Common/tests/TestResults/test-results.trx
Error:
System.ArgumentNullException : Value cannot be null. (Parameter 'node')
Raw output
System.ArgumentNullException : Value cannot be null. (Parameter 'node')
at ArmoniK.Core.Common.gRPC.ExpressionExt.ReplaceExpressionVisitor.Visit(Expression node) in D:\a\ArmoniK.Core\ArmoniK.Core\Common\src\gRPC\ExpressionExt.cs:line 88
at System.Linq.Expressions.ExpressionVisitor.VisitMethodCall(MethodCallExpression node)
at ArmoniK.Core.Common.gRPC.ExpressionExt.ReplaceExpressionVisitor.Visit(Expression node) in D:\a\ArmoniK.Core\ArmoniK.Core\Common\src\gRPC\ExpressionExt.cs:line 91
at ArmoniK.Core.Common.gRPC.ExpressionExt.MakeBinaryExpression[T](ExpressionType expressionType, Expression`1 expr1, Expression`1 expr2) in D:\a\ArmoniK.Core\ArmoniK.Core\Common\src\gRPC\ExpressionExt.cs:line 37
at ArmoniK.Core.Common.gRPC.ExpressionExt.ExpressionAnd[T](Expression`1 expr1, Expression`1 expr2) in D:\a\ArmoniK.Core\ArmoniK.Core\Common\src\gRPC\ExpressionExt.cs:line 54
at ArmoniK.Core.Common.gRPC.ListPartitionsRequestExt.ToPartitionFilter(Filters filters) in D:\a\ArmoniK.Core\ArmoniK.Core\Common\src\gRPC\ListPartitionsRequestExt.cs:line 96
at ArmoniK.Core.Common.Tests.ListPartitionsRequestExt.ToPartitionDataFilterTest.RequestToFunc(Sort sort, IEnumerable`1 filterFields) in D:\a\ArmoniK.Core\ArmoniK.Core\Common\tests\ListPartitionsRequestExt\ToTaskDataFilterTest.cs:line 62
at ArmoniK.Core.Common.Tests.ListPartitionsRequestExt.ToPartitionDataFilterTest.Filter(IEnumerable`1 filterFields, Boolean expected) in D:\a\ArmoniK.Core\ArmoniK.Core\Common\tests\ListPartitionsRequestExt\ToTaskDataFilterTest.cs:line 73
Loading