Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error recovery after retry fail #795

Merged
merged 1 commit into from
Nov 14, 2024
Merged

fix: error recovery after retry fail #795

merged 1 commit into from
Nov 14, 2024

Conversation

aneojgurhem
Copy link
Contributor

@aneojgurhem aneojgurhem commented Nov 13, 2024

Motivation

Follow up of #762. Pending tasks should also be finalized (and inserted into the queue).

Description

During retry process when a task produces an exception, the retry may fail during insertion into the queue system or setting the task to Submitted. When this happen, the task in retried may stay into the queue and re-acquired. We check if the retried task (the new instance) exists and if it exists whith status Creating or Submitted, we finalize its creation. This PR adds also finalize creation of tasks with status Pending.

Testing

Unit tests were added to validate were resubmit properly when the new instance of the task in error is Pending.

Impact

Should fix part of the issue where tasks stay in Pending or Submitted whitout being processed.

Additional Information

We need to try other queue systems to see if the same issue occur with them.

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have thoroughly tested my modifications and added tests when necessary.
  • Tests pass locally and in the CI.
  • I have assessed the performance impact of my modifications.

@aneojgurhem aneojgurhem reopened this Nov 14, 2024
@aneojgurhem aneojgurhem merged commit 4e10a6f into main Nov 14, 2024
97 of 100 checks passed
@aneojgurhem aneojgurhem deleted the jg/pending branch November 14, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants