fix: Allow other network than Ethernet. (#459)

Common/src/Pollster/Pollster.cs

@@ -104,7 +104,7 @@ public Pollster(IPullQueueStorage          pullQueueStorage,
     workerStreamHandler_   = workerStreamHandler;
     agentHandler_          = agentHandler;
     TaskProcessing         = "";
-    ownerPodId_            = LocalIPv4.GetLocalIPv4Ethernet();
+    ownerPodId_            = LocalIpFinder.LocalIpv4Address();
     ownerPodName_          = Dns.GetHostName();
     Failed                 = false;
   }

Common/src/Utils/LocalIpFinder.cs

@@ -0,0 +1,62 @@
+// This file is part of the ArmoniK project
+// 
+// Copyright (C) ANEO, 2021-2023. All rights reserved.
+// 
+// This program is free software: you can redistribute it and/or modify
+// it under the terms of the GNU Affero General Public License as published
+// by the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+// 
+// This program is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY, without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU Affero General Public License for more details.
+// 
+// You should have received a copy of the GNU Affero General Public License
+// along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+using System.Collections.Immutable;
+using System.Linq;
+using System.Net.NetworkInformation;
+using System.Net.Sockets;
+
+using JetBrains.Annotations;
+
+namespace ArmoniK.Core.Common.Utils;
+
+/// <summary>
+///   Helper to get local IP address.
+/// </summary>
+[PublicAPI]
+public class LocalIpFinder
+{
+  /// <summary>
+  ///   Get local IPv4 address from a network interface.
+  /// </summary>
+  /// <param name="type">Interface type from which to get the IP.</param>
+  /// <returns>
+  ///   <see cref="string" /> representing the IP.
+  /// </returns>
+  public static string LocalIpv4Address(NetworkInterfaceType type = NetworkInterfaceType.Ethernet)
+  {
+    var result = NetworkInterface.GetAllNetworkInterfaces()
+                                 .Where(@interface => @interface.OperationalStatus == OperationalStatus.Up)
+                                 .SelectMany(@interface => @interface.GetIPProperties()
+                                                                     .UnicastAddresses.Select(information => information.Address)
+                                                                     .Where(address => address.AddressFamily == AddressFamily.InterNetwork)
+                                                                     .Select(address => (@interface.NetworkInterfaceType, address: address.ToString())))
+                                 .GroupBy(tuple => tuple.NetworkInterfaceType) // there might be several interfaces of the same type
+                                 .ToImmutableDictionary(tuple => tuple.Key,
+                                                        tuple => tuple.Select(valueTuple => valueTuple.address));
+
+    if (result.TryGetValue(type,
+                           out var ethernet))
+    {
+      return ethernet.First();
+    }
+
+    // No interface of desired type ; choose any other available interface and in last resort, the default 127.0.0.1
+    return result.Values.SelectMany(enumerable => enumerable)
+                 .FirstOrDefault("127.0.0.1");
+  }
+}

Common/tests/TestBase/TaskTableTestBase.cs

@@ -921,7 +921,7 @@ public async Task AcquireTaskShouldSucceed()
   {
     if (RunTests)
     {
-      var ownerpodid    = LocalIPv4.GetLocalIPv4Ethernet();
+      var ownerpodid    = LocalIpFinder.LocalIpv4Address();
       var ownerpodname  = Dns.GetHostName();
       var receptionDate = DateTime.UtcNow.Date;
 
@@ -955,7 +955,7 @@ public async Task ReleaseTaskShouldSucceed()
   {
     if (RunTests)
     {
-      var ownerpodid    = LocalIPv4.GetLocalIPv4Ethernet();
+      var ownerpodid    = LocalIpFinder.LocalIpv4Address();
       var ownerpodname  = Dns.GetHostName();
       var receptionDate = DateTime.UtcNow.Date;
       var taskSubmitted = taskSubmittedData_ with
@@ -1004,7 +1004,7 @@ public async Task AcquireAcquiredTaskShouldReturnSame()
   {
     if (RunTests)
     {
-      var hostname = LocalIPv4.GetLocalIPv4Ethernet();
+      var hostname = LocalIpFinder.LocalIpv4Address();
 
       var taskSubmitted = taskSubmittedData_ with
                           {
@@ -1050,7 +1050,7 @@ public async Task AcquireTaskShouldFail()
     {
       var task = taskFailedData_ with
                  {
-                   OwnerPodId = LocalIPv4.GetLocalIPv4Ethernet(),
+                   OwnerPodId = LocalIpFinder.LocalIpv4Address(),
                    OwnerPodName = Dns.GetHostName(),
                    ReceptionDate = DateTime.UtcNow,
                    AcquisitionDate = DateTime.UtcNow,
@@ -1060,7 +1060,7 @@ public async Task AcquireTaskShouldFail()
                                                 CancellationToken.None)
                                    .ConfigureAwait(false);
 
-      Assert.AreNotEqual(LocalIPv4.GetLocalIPv4Ethernet(),
+      Assert.AreNotEqual(LocalIpFinder.LocalIpv4Address(),
                          result.OwnerPodId);
 
       Assert.AreEqual(TaskStatus.Error,
@@ -1075,7 +1075,7 @@ public async Task AcquireCreatingTaskShouldFail()
     {
       var task = taskCreatingData_ with
                  {
-                   OwnerPodId = LocalIPv4.GetLocalIPv4Ethernet(),
+                   OwnerPodId = LocalIpFinder.LocalIpv4Address(),
                    OwnerPodName = Dns.GetHostName(),
                    ReceptionDate = DateTime.UtcNow,
                    AcquisitionDate = DateTime.UtcNow,
@@ -1085,7 +1085,7 @@ public async Task AcquireCreatingTaskShouldFail()
                                                 CancellationToken.None)
                                    .ConfigureAwait(false);
 
-      Assert.AreNotEqual(LocalIPv4.GetLocalIPv4Ethernet(),
+      Assert.AreNotEqual(LocalIpFinder.LocalIpv4Address(),
                          result.OwnerPodId);
 
       Assert.AreEqual(TaskStatus.Creating,