Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BeamSql WktWrapper convert fromProto fix #22

Merged
merged 1 commit into from
Feb 13, 2019
Merged

BeamSql WktWrapper convert fromProto fix #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions transform/src/main/java/io/anemos/protobeam/convert/nodes/beamsql/WktWrapperConvert.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,9 @@ public WktWrapperConvert(Descriptors.FieldDescriptor descriptor) {

@Override
public void fromProto(Message message, Row.Builder row) {
Message nullableWrapperMessage = (Message) message.getField(fieldDescriptor);
// TODO is not correct, need hasField
if (!valueFieldDescriptor.getDefaultValue().equals(nullableWrapperMessage.getField(valueFieldDescriptor))) {
Object value = fromProtoValue(nullableWrapperMessage.getField(valueFieldDescriptor));
if (message.hasField(fieldDescriptor)) {
Message valueMessage = (Message) message.getField(fieldDescriptor);
Object value = fromProtoValue(valueMessage.getField(valueFieldDescriptor));
row.addValue(value);
} else {
row.addValue(null);
Expand Down