Address issue with newer Vulkan for MoltenVK on Mac #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subrepo: subdir: "external/glfw" merged: "2c1d3100" upstream: origin: "https://github.com/glfw/glfw.git" branch: "master" commit: "2c1d3100" git-subrepo: version: "0.4.3" origin: "https://github.com/ingydotnet/git-subrepo" commit: "2f68596"
Vulkan 1.3.216 installation on Mac has the following note: NOTICE: As of the 1.3.216 SDK release, the Vulkan Portability Enumeration extension is being enforced by the Vulkan loader. Failure to 'opt in' for non-conformant Vulkan implementations will cause applications to fail to find the MoltenVK ICD. See the macOS release notes for more information. This commit combined with the update to glfw, addresses these issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 1.3.216, additional layers have to be added to have the drivers work.
This PR adds those and brings glfw in sync.