Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog 3.0 separate file #209

Closed
wants to merge 3 commits into from
Closed

Conversation

andrross
Copy link
Owner

@andrross andrross commented Apr 4, 2024

Description

Testing description with a long line that really goes on and on and on without a line break that one would traditionally add if writing this in a terminal screen.

Related Issues

Resolves opensearch-project#1234

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

andrross and others added 3 commits April 2, 2024 16:17
Contributors and maintainers frequently put changelog entries in the
wrong section. It's an easy mistake to make! Given that making changes
intended for the next minor release is the norm, this change optimizes
that process by making `CHANGELOG.md` contain _only_ entries for the
next minor. Truly breaking changes intended for the next major are kept
in a separate file. Credit to @msfroh for the idea.

Note that the CHANGELOG-3.0.md content is not actually correct, because
it contains mistakes intended to be fixed by this change going
forward! That content can be cleaned up by a follow up PR.

Signed-off-by: Andrew Ross <[email protected]>
Signed-off-by: Kunal Kotwani <[email protected]>
@andrross andrross closed this Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants