-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: updated withdraw fund logic to withdraw the whole balance #509
Closed
Closed
Changes from 3 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
327376a
feat: updated withdraw fund logic to withdraw the whole balance
cowboy0015 57e5f0b
fix: fixed mock
cowboy0015 da25b96
fix: fixed linting error
cowboy0015 bc04323
Merge branch 'development' into feat/withdraw_funds_as_emergency
cowboy0015 d19f676
refactor: refactoring testing framework
cowboy0015 acec7a5
add: added e2e test package
cowboy0015 0817383
refactor: refactored validator staking test with new test package
cowboy0015 3ca8ec3
migrate: migrated from starship to loom
cowboy0015 cf70f4c
test: testing validator_staking -> unstake function
cowboy0015 a63a534
fix: fixed bug in unstaking response handler
cowboy0015 37ea2b0
fix: fixed unstaking logic|
cowboy0015 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,8 @@ | ||
use andromeda_finance::validator_staking::UnstakingTokens; | ||
use cw_storage_plus::{Deque, Item}; | ||
use cw_storage_plus::Item; | ||
|
||
use cosmwasm_std::Addr; | ||
|
||
pub const DEFAULT_VALIDATOR: Item<Addr> = Item::new("default_validator"); | ||
|
||
pub const UNSTAKING_QUEUE: Deque<UnstakingTokens> = Deque::new("unstaking_queue"); | ||
pub const UNSTAKING_QUEUE: Item<Vec<UnstakingTokens>> = Item::new("unstaking_queue"); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optimize the unstaking queue cleanup.
The current logic for removing expired unstaking requests is functional but could be optimized by using
drain_filter
if available in the standard library or a similar method to avoid loading and saving the entire queue.