update to target SDK 35 and dependencies #109
Conversation
|
@calren while updating dependencies, it looks like there was an API change for |
| @@ -160,7 +160,7 @@ private constructor( | |||
| class PreloadStatusControl : TargetPreloadStatusControl<Int> { | |||
| override fun getTargetPreloadStatus(rankingData: Int): DefaultPreloadManager.Status { | |||
| // By default preload first 3 seconds of the video | |||
| return DefaultPreloadManager.Status(STAGE_LOADED_TO_POSITION_MS, 3000L) | |||
| return DefaultPreloadManager.Status(STAGE_LOADED_FOR_DURATION_MS, 3000L) | |||
There was a problem hiding this comment.
@MayuriKhinvasara can you comment on whether this is the right update after updating to the latest media3 release?
There was a problem hiding this comment.
There are a couple of changes to PreloadManager when updating to media3 1.5. We would have to test them before commits.
Can we not include to update the media3 lib to 1.5 ? I can take a separate AI for that (#112). We expect a couple of changes to functioning of PreloadManager in media3 upgrade to 1.5. Will have to test out all those use cases before blanket update |
* update to target SDK 35 and dependencies * revert media dependency
No description provided.