Apply user dark mode preference to splashscreen #1718
+44
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jaehwa-Noh
reviewed
Dec 13, 2024
app/src/main/kotlin/com/google/samples/apps/nowinandroid/MainActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/com/google/samples/apps/nowinandroid/MainActivity.kt
Outdated
Show resolved
Hide resolved
|
There are conflicts now with the PR because of work that I did in the past. But, it will actually simplify your work here, because the only thing now needed is to call the |
Jaehwa-Noh
reviewed
Jan 15, 2025
| @@ -86,6 +90,7 @@ class MainActivity : ComponentActivity() { | |||
| darkTheme = resources.configuration.isSystemInDarkTheme, | |||
| androidTheme = Loading.shouldUseAndroidTheme, | |||
| disableDynamicTheming = Loading.shouldDisableDynamicTheming, | |||
| shouldFollowSystemTheme = Loading.shouldFollowSystemTheme, | |||
There was a problem hiding this comment.
I'm confused why should Follow System Theme need in here? Wouldn't the System Follow Dark Theme being considered before in isSystemInDarkTheme logic?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I have done and why
As previously attempted here, this PR aims to align the splash screen with the user's dark mode preference. However, this solution only works for API >= 31 (see screen recordings below).
API >= 31
API-31-nia.webm
API <= 30
API-30-nia.webm
Related issues/PRs:
#633
#646