-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate compose compiler metrics and reports #1576
Open
Jaehwa-Noh
wants to merge
16
commits into
android:main
Choose a base branch
from
Jaehwa-Noh:integrate-metrics-and-reports
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Integrate compose compiler metrics and reports #1576
Jaehwa-Noh
wants to merge
16
commits into
android:main
from
Jaehwa-Noh:integrate-metrics-and-reports
+13
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I746648d1b11c029a0dcdbac8ca0b8b6487542b0f
…ComposeCompilerReportsAndMetrics". Change-Id: Iaa78284fae1532e728c5f4546ac825b7509e450f
Change-Id: I19409913690df600eee80b6ca98f6ad9dd59f0a0
Change-Id: I550739d630b82c252add80a277fe1248e7577d74
Change-Id: Idbde833767c13f73a46533bf8dc320fc1926a620
Please resolve the conflicts. |
mlykotom
approved these changes
Dec 19, 2024
Change-Id: I60125e6152c2e8e4fc89d0f547521f283259f9de # Conflicts: # build-logic/convention/src/main/kotlin/com/google/samples/apps/nowinandroid/AndroidCompose.kt
...d-logic/convention/src/main/kotlin/com/google/samples/apps/nowinandroid/ProjectExtensions.kt
Outdated
Show resolved
Hide resolved
...d-logic/convention/src/main/kotlin/com/google/samples/apps/nowinandroid/ProjectExtensions.kt
Outdated
Show resolved
Hide resolved
build-logic/convention/src/main/kotlin/com/google/samples/apps/nowinandroid/AndroidCompose.kt
Outdated
Show resolved
Hide resolved
...d-logic/convention/src/main/kotlin/com/google/samples/apps/nowinandroid/ProjectExtensions.kt
Outdated
Show resolved
Hide resolved
Change-Id: I06ad3d172310307307f681fb985a9e0b25c0d89c
Change-Id: Id398829fe7cef18a40fd8af81f865e2457ebb125
Change-Id: Ied6c95a4a18668c78419b6cfee3aa5303def3bf9 # Conflicts: # build-logic/convention/src/main/kotlin/com/google/samples/apps/nowinandroid/AndroidCompose.kt
build-logic/convention/src/main/kotlin/com/google/samples/apps/nowinandroid/AndroidCompose.kt
Outdated
Show resolved
Hide resolved
build-logic/convention/src/main/kotlin/com/google/samples/apps/nowinandroid/AndroidCompose.kt
Outdated
Show resolved
Hide resolved
Change-Id: Ib7b8ade051985dd6a3e698d562d420a67ca5e9c4
Change-Id: I3bd98543d424f51493b4cc99c8bd677af61df787
Change-Id: I7394985e72fbd33636be2a6947802075e0a1a9c0
Change-Id: If07d80679c2546be0ab719c9ec76e3da42c49370
build-logic/convention/src/main/kotlin/com/google/samples/apps/nowinandroid/AndroidCompose.kt
Outdated
Show resolved
Hide resolved
Change-Id: If5e6ecaac44dd065c6fbdabe8e7c7f9b0dea8ee5
…nto integrate-metrics-and-reports Change-Id: I75010fd05debf8dcdab16b062b13a56851a82bca
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I have done and why
From this blog https://chrisbanes.me/posts/composable-metrics/, and commonly we get reports and metrics both at the same time.
So I'd integrated two manual Property into one custom Property.