Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump spotless(6.23.3 to 6.25.0) and ktlint(1.0.1 to 1.4.0) #1318

Merged
merged 5 commits into from
Dec 9, 2024
Merged

Bump spotless(6.23.3 to 6.25.0) and ktlint(1.0.1 to 1.4.0) #1318

merged 5 commits into from
Dec 9, 2024

Conversation

Jaehwa-Noh
Copy link
Contributor

@Jaehwa-Noh Jaehwa-Noh commented Mar 22, 2024 •
edited
Loading

What I have done and why
Bump spotless(6.23.3 to 6.25.0) and ktlint(1.0.1 to 1.2.1) up

I just wonder why dependency bot doesn't care this dependency.

@Jaehwa-Noh
Bump up
c20d609 
- spotless.
- ktlint.

Change-Id: I4a0d1b4089dd4882df4653303a52f07f2bf6771f
@SimonMarquis
Copy link
Contributor

Dependabot only checks for specific locations, and this is not using the standard Gradle version catalog.

@Jaehwa-Noh
Copy link
Contributor Author

I got it. Thank you!

blue928sky
blue928sky reviewed Oct 25, 2024
View reviewed changes
gradle/init.gradle.kts Outdated Show resolved Hide resolved
@android android deleted a comment from Vladimir-cod Oct 29, 2024
dturner
dturner reviewed Oct 29, 2024
View reviewed changes
gradle/init.gradle.kts Outdated Show resolved Hide resolved
@dturner dturner changed the title Bump spotless(6.23.3 to 6.25.0) and ktlint(1.0.1 to 1.2.1) Bump spotless(6.23.3 to 6.25.0) and ktlint(1.0.1 to 1.4.0) Oct 29, 2024
@dturner
Copy link
Collaborator

dturner commented Oct 29, 2024

The updated version of ktlint changes the formatting rules which causes the build to fail.

@Jaehwa-Noh Would you be able to take a look at how to disable the new rules so that our existing codebase isn't affected? This post might be useful: android/compose-samples#1443 (comment)

@Jaehwa-Noh
Copy link
Contributor Author

@dturner Okay, I'll get it as soon as possible.
I need a spare time.

@Jaehwa-Noh
Merge branch 'refs/heads/android-remote-main' into bump-up
2d690d7 
Change-Id: I3331ade9f99effcf274880d87c48b00fcacfcc2b
@Jaehwa-Noh
Disable all new features since ktlint 1.3.0.
722b3f5 
https://github.com/pinterest/ktlint/releases/tag/1.3.0

Change-Id: I8f0ea640c06a2266cf0b7ede0da06bdd32651bbc
@Jaehwa-Noh
Disabled ktlint_standard_function-signature.
8c1e06e 
Change-Id: Ib3e6e66d1774b39b5c92ec822308db107b070b82
@Jaehwa-Noh
Copy link
Contributor Author

Jaehwa-Noh commented Oct 31, 2024 •
edited
Loading

@dturner
I'd removed new features all which is added in version ktlint 1.3.0(https://github.com/pinterest/ktlint/releases/tag/1.3.0), but still need to change some code styles.
It was as though some inner code's behaviors had changed.
So that, I've disabled Function signature too, https://pinterest.github.io/ktlint/latest/rules/standard/#function-signature
Would you see the Function signature rule and select which option one? enabled, disabled, default, multiline, always.
Disabled currently.

@keyboardsurfer keyboardsurfer merged commit 1881730 into android:main Dec 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blue928sky blue928sky blue928sky left review comments

@dturner dturner dturner approved these changes

@keyboardsurfer keyboardsurfer keyboardsurfer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Jaehwa-Noh @SimonMarquis @dturner @keyboardsurfer @blue928sky