Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduced view that shows only configured pins #828

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Conversation

andrewdavidmackenzie
Copy link
Owner

Fixes #756

@andrewdavidmackenzie
Copy link
Owner Author

Here are a couple of examples when there are only a few pins configured, without scroll bars.

Screenshot 2025-01-28 at 6 56 27 PM Screenshot 2025-01-28 at 6 56 45 PM

I have an idea how to add more configured pins without switching back to one of the other views.

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 12.03704% with 95 lines in your changes missing coverage. Please review.

Project coverage is 28%. Comparing base (f43b7cb) to head (8d4f656).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/views/layout_menu.rs 0% 42 Missing ⚠️
src/views/hardware_view.rs 0% 34 Missing ⚠️
src/file_helper.rs 0% 14 Missing ⚠️
src/piggui.rs 0% 5 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##           master   #828   +/-   ##
=====================================
- Coverage      28%    28%   -0%     
=====================================
  Files          47     48    +1     
  Lines        5925   5979   +54     
=====================================
+ Hits         1625   1626    +1     
- Misses       4300   4353   +53     
Flag Coverage Δ
unittests 28% <13%> (-<1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewdavidmackenzie andrewdavidmackenzie merged commit b040696 into master Jan 28, 2025
17 checks passed
@andrewdavidmackenzie andrewdavidmackenzie deleted the pigg_756 branch January 28, 2025 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom layout
1 participant