Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add typeKey #147

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

feat: add typeKey #147

wants to merge 6 commits into from

Conversation

Ayc0
Copy link

@Ayc0 Ayc0 commented Aug 26, 2024

Fix #138. Variation of #139 using typeKey instead of typeField

  • Add new option typeKey?: string for deserialization to include all JSON:API types during deserialization
  • During serialization, will check if typeKey matches the provided type (but keep typeKey optional)
  • Regenerate docs

@Ayc0 Ayc0 changed the title feat: add typeKey feat: add typeKey Aug 26, 2024
Copy link

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 15 days.

@github-actions github-actions bot added the Stale label Oct 26, 2024
@Ayc0
Copy link
Author

Ayc0 commented Oct 28, 2024

I'm wondering if we can't allow for string | symbol to cover both PR cases? 🤔

@github-actions github-actions bot removed the Stale label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support type in deserialized data
1 participant