Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3122 valid license url characters #3449

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

3122 valid license url characters #3449

wants to merge 2 commits into from

Conversation

spiffcs
Copy link
Contributor

@spiffcs spiffcs commented Nov 17, 2024 •
edited
Loading

Description

This PR updates the license constructors to strip unwanted characters from URLs in license metadata and make sure all URLs conform to RFC 3987 IRI-reference.

Fix Validation

  • Download .jar file here
  • Run the following command using this branch:
    go run cmd/syft/main.go --output cyclonedx-json=file.json --verbose

The URL now listed for the UserAgentUtils should no longer have special characters in it as listed in the issue.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have added unit tests that cover changed behavior
  • I have tested my code in common scenarios and confirmed there are no regressions
  • I have added comments to my code, particularly in hard-to-understand sections

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Special characters (tab, newline) in license URL
1 participant
@spiffcs