Support scanning files in mount namespaces #3423
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although syft supports scanning an entire chroot, it couldn't scan paths inside the chroot containing absolute symlinks relative to the chroot base until now. This is the first step in supporting scanning files/directories in other mount namespaces, since a different mount namespace is similar to a chroot. The main change is the addition to EvalSymlinksRelativeToBase, which can resolve both regular symlinks and absolute symlinks confined in a chroot-like directory structure. This function returns a path that can be accessed in syft's scanning context, i.e. not meant to be used from within the chroot context. See anchore#3396 for further discussions. Signed-off-by: Ariel Miculas-Trif <[email protected]>
See anchore#3396 Signed-off-by: Ariel Miculas-Trif <[email protected]>
Fixes anchore#3396 Signed-off-by: Ariel Miculas-Trif <[email protected]>
|
@kzantow could I have some reviews for this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Checklist: