Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating indentation for pre upgrade job resources #344

Merged
merged 2 commits into from
Feb 9, 2024
Merged

updating indentation for pre upgrade job resources #344

merged 2 commits into from
Feb 9, 2024

Conversation

HN23
Copy link
Member

@HN23 HN23 commented Feb 9, 2024

we will need to update the lock file after #343 is merged.

values.yaml:

  containerSecurityContext:
    allowPrivilegeEscalation: false
    capabilities:
      drop:
      - all
    privileged: false
    runAsNonRoot: true

and

  upgradeJob:
    resources:
      limits:
        cpu: 1
        memory: 1G
      requests:
        cpu: 100m
        memory: 256M

@HN23 HN23 requested a review from osiagwe February 9, 2024 19:28
@HN23 HN23 requested a review from a team as a code owner February 9, 2024 19:28
Btodhunter
Btodhunter previously approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@Btodhunter Btodhunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Btodhunter Btodhunter force-pushed the enterprise-upgradejob-resources branch from c0ee648 to 1a500ac Compare February 9, 2024 22:26
@Btodhunter Btodhunter merged commit 302d4d3 into main Feb 9, 2024
9 checks passed
@Btodhunter Btodhunter deleted the enterprise-upgradejob-resources branch February 9, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Btodhunter Btodhunter Btodhunter approved these changes

@osiagwe osiagwe Awaiting requested review from osiagwe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HN23 @Btodhunter