Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test mr #97

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test mr #97

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions serverless.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,3 +24,7 @@ functions:
- httpApi:
path: /api/github/webhooks
method: post
memorySize:
- 256
timeout: 30
logRetentionInDays: 14
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code patch seems to be adding a configuration to a serverless function.

The added memorySize value sets the maximum amount of memory that can be allocated to the function, which could affect its performance depending on the workload.

The timeout value sets the maximum execution time of the function, after which it will be terminated.

The logRetentionInDays value sets how long the logs generated by the function should be retained.

These changes seem reasonable and there are no obvious bugs. However, without knowledge of the context or the rest of the codebase, it's difficult to say if these changes will be sufficient or optimal for your use case.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code patch adds two new configuration options to a function:

  1. memorySize is set to 256. This determines the amount of memory allocated to the function. It's important to ensure that this value is high enough to prevent out-of-memory errors, but not so high that it wastes resources.

  2. logRetentionInDays is set to 14. This determines how long CloudWatch logs are retained for the function. The default is indefinitely, but setting a retention period can be useful for managing costs and compliance.

There don't appear to be any bug risks with this code patch. However, it would be helpful to confirm that the existing configuration options set elsewhere in the file are appropriate for this function. Additionally, it may be worth considering whether the timeout value of 30 seconds is sufficient for this function's expected runtime.