Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

projects: ad7616-sdz: Fix defines for HDL #2425

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ahaslam2
Copy link
Collaborator

This fix compilation with recent HDL changes

Pull Request Description

Please replace this with a detailed description and motivation of the changes.
You can tick the checkboxes below with an 'x' between square brackets or just check them after publishing the PR.
If this PR contains a breaking change, list dependent PRs and try to push all related PRs at the same time.

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the Coding style guidelines
  • I have performed a self-review of the changes
  • I have commented my code, at least hard-to-understand parts
  • I have build all projects affected by the changes in this PR
  • I have tested in hardware affected projects, at the relevant boards
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe etc), if applies

This fix compilation with recent HDL changes

Signed-off-by: Axel Haslam <[email protected]>
@buha
Copy link
Contributor

buha commented Jan 28, 2025

looks good, why is it a draft ?
CI test for xilinx passed

@ahaslam2
Copy link
Collaborator Author

looks good, why is it a draft ? CI test for xilinx passed

just want to test on real hw that it works and then ill remove "draft"

@ahaslam2 ahaslam2 marked this pull request as ready for review January 28, 2025 14:46
@ahaslam2
Copy link
Collaborator Author

ahaslam2 commented Jan 28, 2025

this patch fixes the build
i quickly try to test on zedboard but the spi read at init was not returning for some reason that needs to be debugged further. (i build the HDL with make INTF=1)

@buha
Copy link
Contributor

buha commented Jan 29, 2025

Ok, given that XPAR_AXI_AD7616_BASEADDR and the SPI issue could be related I'm not going to merge for now, until you have a fix. If we're 100% sure XPAR_AXI_AD7616_BASEADDR is correct then I could merge it and treat these as separate issues, this one fixes the build (and I'd merge it), the other fix will address the SPI init issue. Let me know.

@ahaslam2
Copy link
Collaborator Author

@buha im sure XPAR_AXI_AD7616_BASEADDR is correct. i think you can merge this.
i need to find some time to look at the HW setup (there is a resistor to change serial/parallel modes)
and probe the spi lines to see what is going on with this project... it might have been my setup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants