migrate some projects to new example infrastructure #2420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the necessary changes to use the new example infrastructure. Signed-off-by: Darius Berghe <[email protected]>
Make the necessary changes to use the new example infrastructure. Signed-off-by: Darius Berghe <[email protected]>
buha
requested review from
CiprianRegus,
dbogdan,
amiclaus,
rbolboac and
danmois
as code owners
buha
force-pushed
the
staging/examples3
branch
from
79a2272 to
7fd64a7
Compare
buha
commented
Jan 23, 2025
| struct no_os_irq_ctrl_desc *nvic_desc; | ||
| struct no_os_irq_init_param nvic_ip = { | ||
| .platform_ops = &max_irq_ops, | ||
| }; | ||
| struct no_os_gpio_desc *adxl355_gpio_desc; | ||
|
|
||
| /* Initialize DATA READY pin */ | ||
| ret = no_os_gpio_get_optional(&adxl355_gpio_desc, &adxl355_gpio_drdy_ip); |
There was a problem hiding this comment.
this DRDY pin is really weird, it's initialized for the iio_trigger_example (aducm3029 and maxim BUT NOT stm32!) but it's not used anywhere, so if anyone has an explanation for this let me know
There was a problem hiding this comment.
@CiprianRegus came with a good explanation, on stm32, EXTI is automatically configured as GPIO input by the HAL but on aducm3029 and maxim, it's not, so this extra step is needed. In the modified code, this is kept so I don't think it will break anything.
Make the necessary changes to use the new example infrastructure. Signed-off-by: Darius Berghe <[email protected]>
Make the necessary changes to use the new example infrastructure. Signed-off-by: Darius Berghe <[email protected]>
Make the necessary changes to use the new example infrastructure. Signed-off-by: Darius Berghe <[email protected]>
Make the necessary changes to use the new example infrastructure. Signed-off-by: Darius Berghe <[email protected]>
Make the necessary changes to use the new example infrastructure. Signed-off-by: Darius Berghe <[email protected]>
buha
force-pushed
the
staging/examples3
branch
from
7fd64a7 to
6a0c60c
Compare
Make the necessary changes to use the new example infrastructure. Signed-off-by: Darius Berghe <[email protected]>
buha
force-pushed
the
staging/examples3
branch
from
6a0c60c to
52820bb
Compare
|
V2:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migrates several projects to the new example infrastructure, most important being adxl355 which was used as template for many others.
PR Type
PR Checklist