M2kAnalogIn: sync calibration state with device attributes #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Adrian-Stanea
commented
Sep 27, 2023
Adrian-Stanea
commented
- Use device attributes in class instance for calibration at the SW level, samples should be sent uncalibrated.
- Current firmware uses device attr to send calibrated samples by the HW. To simulate future firmware behaviour where samples are not calibrated we store the calibration result in the class instance, but don't write them to device attributes.
Adrian-Stanea
force-pushed
the
fw_calib_in_sw
branch
from
5813e67 to
8f05a32
Compare
- Sync class parameters: m_adc_calib_offset, m_adc_calib_gain with device attributes. These are used to calibrate the raw data to volts. - In firmware version 0.32, the device attribute won't be used by the hardware, samples will be recieved uncalibrated. The calibration will be done in software.
- in new firmware version the calibration is done in SW. Params will be written in the device attr but not used at the HW level. Raw samples are sent without calibration and the calibration is done in SW. - this patch is for debug purpose only. It updates calibration params only for the class instance but not in the device attr. This way we simulate calibration where samples are sent without calibration at HW level. Signed-off-by: Adrian Stanea <[email protected]>
Adrian-Stanea
force-pushed
the
fw_calib_in_sw
branch
from
8f05a32 to
65a8728
Compare
…ibration attr
- Sync class parameters: m_adc_calib_offset, m_adc_calib_gain with device attributes.
These are used to calibrate the raw data to volts.
- In firmware version 0.32, the device attribute won't be used by the hardware,
samples will be recieved uncalibrated. The calibration will be done in software.
- I new libm2k, use the calibration attr is used to disable setting the computed calibration values in HW.
- Note:
- set calibration = 'true' (string vale): stops the HW calibration
- set calibration = 'false' (string value): enables the HW calibration
Signed-off-by: Adrian Stanea <[email protected]>
- current firmware still has name starting with 0.31 - Future release will have name starting with 0.32, and the new calibration attr will be used. Signed-off-by: Adrian Stanea <[email protected]>
|
Tested potential fix in old firmware. The solution is ambiguous since it leads to calibrate call that wont be reflected in the iio attributes, only in class instance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.