Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes invalid IIOD_EXTRA_OPTS assignment #1208

Open
wants to merge 1 commit into
base: libiio-v0
Choose a base branch
from

Conversation

dennis-ju
Copy link
Contributor

@dennis-ju dennis-ju commented Oct 24, 2024

PR Description

Fixing an invalid assignment of IIOD_EXTRA_OPTS in the service file. Causing the warning "Referenced but unset environment variable evaluates to an empty string: IIOD_EXTRA_OPTS" if not set in /etc/default/iiod.

Fixes #1142.

PR Type

  • Bug fix (a change that fixes an issue)
  • New feature (a change that adds new functionality)
  • Breaking change (a change that affects other repos or cause CIs to fail)

PR Checklist

  • I have conducted a self-review of my own code changes
  • I have commented new code, particulary complex or unclear areas
  • I have checked that I did not intoduced new warnings or errors (CI output)
  • I have checked that components that use libiio did not get broken
  • I have updated the documentation accordingly (GitHub Pages, READMEs, etc)

@dennis-ju dennis-ju changed the title Fixed invalid IIOD_EXTRA_OPTS assignment Fixes invalid IIOD_EXTRA_OPTS assignment Oct 24, 2024
@rgetz
Copy link
Contributor

rgetz commented Oct 25, 2024

I would put something in the commit message about:

removing extraneous $ that was part of : a436ad6

@rgetz
Copy link
Contributor

rgetz commented Oct 25, 2024

and same fix is needed in main branch

Removing extraneous $ in the assignment of IIOD_EXTRA_OPTS in the
service file that was part of analogdevicesinc@a436ad6

Fixes analogdevicesinc#1142.

Signed-off-by: Dennis Jusufovic <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants