Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V22.2.1 #151

Merged
merged 8 commits into from
Aug 4, 2023
Merged

V22.2.1 #151

merged 8 commits into from
Aug 4, 2023

Conversation

SrikanthPagadarai
Copy link
Contributor

No description provided.

Comment on lines 107 to 109
sed -i 's@source ../../scripts/adi_env.tcl@source ../../../scripts/adi_env.tcl@' $TARGET/library/util_sync/sync_delay/util_delay_ip.tcl
sed -i 's@source ../../scripts/adi_env.tcl@source ../../../scripts/adi_env.tcl@' $TARGET/library/util_sync/sync_fast_to_slow/sync_fast_to_slow_ip.tcl
sed -i 's@source ../../scripts/adi_env.tcl@source ../../../scripts/adi_env.tcl@' $TARGET/library/util_sync/sync_slow_to_fast/sync_slow_to_fast_ip.tcl
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be done in the source files themselves since it will make them easier to upstream.

Copy link
Contributor Author

@SrikanthPagadarai SrikanthPagadarai Aug 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An updated commit fixes this.

Copy link
Collaborator

@tfcollins tfcollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI issues point to missing update of custom files to include new "scripts" folder in plugin_rd.m files in CustomFiles settings

- Xilinx Vivado 2021.1
- Xilinx SDK 2021.1
- Xilinx Vivado 2021.2
- Xilinx SDK 2021.2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should reference Vitis as the SDK doesn't exist anymore

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@SrikanthPagadarai
Copy link
Contributor Author

CI issues point to missing update of custom files to include new "scripts" folder in plugin_rd.m files in CustomFiles settings

HDLFH demo and TuneAGC demo updated. KernelFH demo needs an updated patch.

@tfcollins tfcollins merged commit bca4ea6 into master Aug 4, 2023
2 checks passed
@tfcollins tfcollins deleted the v22_2_1 branch August 4, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants