Display download bar in all cases and make the timeout configurable via an env var #401
+17
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have observed two issues when files are downloaded in the prepare phase:
Content-Length
lead to no download bar being displayed at allThis PR addresses 1) by displaying a progress bar in any case, so the user is aware of some sort of progress. They can also see if it hangs and decide to abort if so.
2 isn't fully addressed, instead, the default timeout of 10 minutes is made configurable via the
ANACONDA_PROJECT_DOWNLOADS_TIMEOUT
environment variable. I guess the best approach would be to implement a timeout that is raised only when no new chunk is received after X seconds, instead of setting a global request timeout.The current default timeout of 10 minutes could also be increased, 10 minutes is quite short when downloading big files.