Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display download bar in all cases and make the timeout configurable via an env var #401

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

maximlt
Copy link
Collaborator

@maximlt maximlt commented Feb 9, 2024

We have observed two issues when files are downloaded in the prepare phase:

  1. Responses without Content-Length lead to no download bar being displayed at all
  2. Downloads longer than 10 minutes time out

This PR addresses 1) by displaying a progress bar in any case, so the user is aware of some sort of progress. They can also see if it hangs and decide to abort if so.

image

2 isn't fully addressed, instead, the default timeout of 10 minutes is made configurable via the ANACONDA_PROJECT_DOWNLOADS_TIMEOUT environment variable. I guess the best approach would be to implement a timeout that is raised only when no new chunk is received after X seconds, instead of setting a global request timeout.

The current default timeout of 10 minutes could also be increased, 10 minutes is quite short when downloading big files.

@maximlt
Copy link
Collaborator Author

maximlt commented Feb 10, 2024

@AlbertDeFusco I've been told to ping you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant