addressed PR comments

Signed-off-by: Amardeepsingh Siglani <[email protected]>
amsiglan · Jul 28, 2023 · bb9f1d9 · bb9f1d9
1 parent ad1bb6d
commit bb9f1d9
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/public/store/LogTypeStore.ts b/public/store/LogTypeStore.ts
@@ -7,6 +7,7 @@ import { NotificationsStart } from 'opensearch-dashboards/public';
 import { LogType, LogTypeBase, LogTypeItem } from '../../types';
 import LogTypeService from '../services/LogTypeService';
 import { errorNotificationToast } from '../utils/helpers';
+import { DataStore } from './DataStore';
 
 export class LogTypeStore {
   constructor(private service: LogTypeService, private notifications: NotificationsStart) {}
@@ -21,7 +22,11 @@ export class LogTypeStore {
         };
       });
 
-      return { ...logTypes[0], detectionRules: 10 };
+      const rulesRes = await DataStore.rules.getAllRules({
+        'rule.category': [id],
+      });
+
+      return { ...logTypes[0], detectionRules: rulesRes.length };
     }
 
     return undefined;

diff --git a/server/services/LogTypeService.ts b/server/services/LogTypeService.ts
@@ -114,7 +114,6 @@ export class LogTypeService {
       const { logTypeId } = request.params;
       const params: UpdateLogTypeParams = { body: logType, logTypeId };
       const { callAsCurrentUser: callWithRequest } = this.osDriver.asScoped(request);
-      console.log(JSON.stringify(params));
       const updateLogTypeResponse: UpdateLogTypeResponse = await callWithRequest(
         CLIENT_LOGTYPE_METHODS.UPDATE_LOGTYPE,
         params