Bundlesize follow-up #14459
Merged
Bundlesize follow-up #14459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e process on failure.
rsimha
reviewed
Apr 6, 2018
gulpfile.js
Outdated
| const cmd = `npx bundlesize -f "${file}" -s "${size}"`; | ||
| log(green('Running ') + cyan(cmd) + green('...\n')); | ||
| const p = exec(cmd); | ||
| if (p.status != 0) { | ||
| log(red('ERROR:'), cyan('bundlesize'), 'found that amp.js/v0.js has ' + | ||
| 'exceeded its size cap. This is part of a new effort to reduce ' + | ||
| 'AMP\'s binary size (#14392). Please contact @choumx for assistance.'); | ||
| process.exit(p.status); |
There was a problem hiding this comment.
Do you want to do this during local dev as well? Perhaps gate this on process.env.TRAVIS?
rsimha
approved these changes
Apr 6, 2018
glevitzky
pushed a commit
that referenced
this pull request
Apr 27, 2018
* Bump v0.js bundle size limit to account for --fortesting and terminate process on failure. * Only terminate process on Travis.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #14405.
--fortesting/to @rsimha