[BREAKING CHANGES] fix: issue related to missing some auto instrumentation tracing data #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
overbit
force-pushed
the
fix-missing-autoinstrumentation-issues
branch
from
3c2d58b to
a53d54b
Compare
overbit
force-pushed
the
fix-missing-autoinstrumentation-issues
branch
from
a53d54b to
5d87cac
Compare
… were loaded after the targeting lib i.e. graphql BREAKING CHANGE: the tracing SDK initialisation is now independent from the TracingModule
overbit
force-pushed
the
fix-missing-autoinstrumentation-issues
branch
from
5d87cac to
33fe13c
Compare
overbit
changed the title
overbit
commented
Feb 29, 2024
overbit
force-pushed
the
fix-missing-autoinstrumentation-issues
branch
from
2eec4fb to
08c0ead
Compare
abrl91
approved these changes
Feb 29, 2024
|
🎉 This PR is included in version 5.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: amplication/amplication#8154
Due to the v4 way of instantiating the opentelemetry nodesdk provider, it was not possible to benefit from some of the auto-instrumentation libraries.
This was due to the fact that most of these are working by re-wiring the target libraries (like
@opentelemetry/instrumentation-graphqlwithgraphql) and the order of import of the instrumentation and target library is vital for a working solution.The breaking change of this PR is related to the instantiation flow, splitting the autoTracingInjectors that trace nestjs resources from the NodeSDK instantiation.
More details in the README