Improve verify_data function
#138
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automatically parse allowed data types rather than manual specification. Additional checks if data are of type `matrix` are left in.
hanneoberman
requested changes
Dec 20, 2023
R/utils.R
Outdated
| call. = FALSE | ||
| ) | ||
| } | ||
| if (is.matrix(data)) { | ||
| if (dim(data)[1] != dim(data)[2]) { |
There was a problem hiding this comment.
This check is actually a bug in ggmice, because mice does accept non-square predictor matrices
|
I believe that a better solution would be https://rlang.r-lib.org/reference/arg_match.html |
|
Maybe using
|
Edit preprocessing function for checking data. Add (and implement) preprocessing function for extracting variable names.
|
Should also resolve #130 |
|
Status check: might not be necessary anymore. Converting to draft. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically parse allowed data types rather than manual specification. Additional checks if data are of type
matrixare left in. Should resolve #85