Skip to content

Commit

Permalink
Added ParamsParser to FrameTransformGet_nws_ros2
Browse files Browse the repository at this point in the history
Signed-off-by: Ettore Landini <[email protected]>
  • Loading branch information
elandini84 committed Aug 26, 2024
1 parent 4e10399 commit fdb6f33
Show file tree
Hide file tree
Showing 6 changed files with 254 additions and 42 deletions.
3 changes: 3 additions & 0 deletions src/devices/frameTransformGet_nwc_ros2/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,14 @@ yarp_prepare_plugin(frameTransformGet_nwc_ros2

if(NOT SKIP_frameTransformGet_nwc_ros2)
yarp_add_plugin(yarp_frameTransformGet_nwc_ros2)
generateDeviceParamsParser(FrameTransformGet_nwc_ros2 frameTransformGet_nwc_ros2)

target_sources(yarp_frameTransformGet_nwc_ros2
PRIVATE
frameTransformGet_nwc_ros2.cpp
frameTransformGet_nwc_ros2.h
FrameTransformGet_nwc_ros2_ParamsParser.h
FrameTransformGet_nwc_ros2_ParamsParser.cpp
)

target_include_directories(yarp_frameTransformGet_nwc_ros2 PRIVATE
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,159 @@
/*
* SPDX-FileCopyrightText: 2023-2023 Istituto Italiano di Tecnologia (IIT)
* SPDX-License-Identifier: LGPL-2.1-or-later
*/


// Generated by yarpDeviceParamParserGenerator (1.0)
// This is an automatically generated file. Please do not edit it.
// It will be re-generated if the cmake flag ALLOW_DEVICE_PARAM_PARSER_GERNERATION is ON.

// Generated on: Mon Aug 26 14:52:35 2024


#include "FrameTransformGet_nwc_ros2_ParamsParser.h"
#include <yarp/os/LogStream.h>
#include <yarp/os/Value.h>

namespace {
YARP_LOG_COMPONENT(FrameTransformGet_nwc_ros2ParamsCOMPONENT, "yarp.device.FrameTransformGet_nwc_ros2")
}


FrameTransformGet_nwc_ros2_ParamsParser::FrameTransformGet_nwc_ros2_ParamsParser()
{
}


std::vector<std::string> FrameTransformGet_nwc_ros2_ParamsParser::getListOfParams() const
{
std::vector<std::string> params;
params.push_back("GENERAL::refresh_interval");
params.push_back("ROS2::ft_node");
params.push_back("ROS2::ft_topic");
params.push_back("ROS2::ft_topic_static");
return params;
}


bool FrameTransformGet_nwc_ros2_ParamsParser::parseParams(const yarp::os::Searchable & config)
{
//Check for --help option
if (config.check("help"))
{
yCInfo(FrameTransformGet_nwc_ros2ParamsCOMPONENT) << getDocumentationOfDeviceParams();
}

std::string config_string = config.toString();
yarp::os::Property prop_check(config_string.c_str());
//Parser of parameter GENERAL::refresh_interval
{
yarp::os::Bottle sectionp;
sectionp = config.findGroup("GENERAL");
if (sectionp.check("refresh_interval"))
{
m_GENERAL_refresh_interval = sectionp.find("refresh_interval").asFloat64();
yCInfo(FrameTransformGet_nwc_ros2ParamsCOMPONENT) << "Parameter 'GENERAL::refresh_interval' using value:" << m_GENERAL_refresh_interval;
}
else
{
yCInfo(FrameTransformGet_nwc_ros2ParamsCOMPONENT) << "Parameter 'GENERAL::refresh_interval' using DEFAULT value:" << m_GENERAL_refresh_interval;
}
prop_check.unput("GENERAL::refresh_interval");
}

//Parser of parameter ROS2::ft_node
{
yarp::os::Bottle sectionp;
sectionp = config.findGroup("ROS2");
if (sectionp.check("ft_node"))
{
m_ROS2_ft_node = sectionp.find("ft_node").asString();
yCInfo(FrameTransformGet_nwc_ros2ParamsCOMPONENT) << "Parameter 'ROS2::ft_node' using value:" << m_ROS2_ft_node;
}
else
{
yCInfo(FrameTransformGet_nwc_ros2ParamsCOMPONENT) << "Parameter 'ROS2::ft_node' using DEFAULT value:" << m_ROS2_ft_node;
}
prop_check.unput("ROS2::ft_node");
}

//Parser of parameter ROS2::ft_topic
{
yarp::os::Bottle sectionp;
sectionp = config.findGroup("ROS2");
if (sectionp.check("ft_topic"))
{
m_ROS2_ft_topic = sectionp.find("ft_topic").asString();
yCInfo(FrameTransformGet_nwc_ros2ParamsCOMPONENT) << "Parameter 'ROS2::ft_topic' using value:" << m_ROS2_ft_topic;
}
else
{
yCInfo(FrameTransformGet_nwc_ros2ParamsCOMPONENT) << "Parameter 'ROS2::ft_topic' using DEFAULT value:" << m_ROS2_ft_topic;
}
prop_check.unput("ROS2::ft_topic");
}

//Parser of parameter ROS2::ft_topic_static
{
yarp::os::Bottle sectionp;
sectionp = config.findGroup("ROS2");
if (sectionp.check("ft_topic_static"))
{
m_ROS2_ft_topic_static = sectionp.find("ft_topic_static").asString();
yCInfo(FrameTransformGet_nwc_ros2ParamsCOMPONENT) << "Parameter 'ROS2::ft_topic_static' using value:" << m_ROS2_ft_topic_static;
}
else
{
yCInfo(FrameTransformGet_nwc_ros2ParamsCOMPONENT) << "Parameter 'ROS2::ft_topic_static' using DEFAULT value:" << m_ROS2_ft_topic_static;
}
prop_check.unput("ROS2::ft_topic_static");
}

/*
//This code check if the user set some parameter which are not check by the parser
//If the parser is set in strict mode, this will generate an error
if (prop_check.size() > 0)
{
bool extra_params_found = false;
for (auto it=prop_check.begin(); it!=prop_check.end(); it++)
{
if (m_parser_is_strict)
{
yCError(FrameTransformGet_nwc_ros2ParamsCOMPONENT) << "User asking for parameter: "<<it->name <<" which is unknown to this parser!";
extra_params_found = true;
}
else
{
yCWarning(FrameTransformGet_nwc_ros2ParamsCOMPONENT) << "User asking for parameter: "<< it->name <<" which is unknown to this parser!";
}
}
if (m_parser_is_strict && extra_params_found)
{
return false;
}
}
*/
return true;
}


std::string FrameTransformGet_nwc_ros2_ParamsParser::getDocumentationOfDeviceParams() const
{
std::string doc;
doc = doc + std::string("\n=============================================\n");
doc = doc + std::string("This is the help for device: FrameTransformGet_nwc_ros2\n");
doc = doc + std::string("\n");
doc = doc + std::string("This is the list of the parameters accepted by the device:\n");
doc = doc + std::string("'GENERAL::refresh_interval': The time interval outside which timed ft will be deleted\n");
doc = doc + std::string("'ROS2::ft_node': The name of the ROS2 node\n");
doc = doc + std::string("'ROS2::ft_topic': The name of the ROS2 topic from which fts will be received\n");
doc = doc + std::string("'ROS2::ft_topic_static': The name of the ROS2 topic from which static fts will be received\n");
doc = doc + std::string("\n");
doc = doc + std::string("Here are some examples of invocation command with yarpdev, with all params:\n");
doc = doc + " yarpdev --device frameTransformGet_nwc_ros2 --GENERAL::refresh_interval 0.1 --ROS2::ft_node tfNodeGet --ROS2::ft_topic /tf --ROS2::ft_topic_static /tf_static\n";
doc = doc + std::string("Using only mandatory params:\n");
doc = doc + " yarpdev --device frameTransformGet_nwc_ros2\n";
doc = doc + std::string("=============================================\n\n"); return doc;
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,78 @@
/*
* SPDX-FileCopyrightText: 2023-2023 Istituto Italiano di Tecnologia (IIT)
* SPDX-License-Identifier: LGPL-2.1-or-later
*/


// Generated by yarpDeviceParamParserGenerator (1.0)
// This is an automatically generated file. Please do not edit it.
// It will be re-generated if the cmake flag ALLOW_DEVICE_PARAM_PARSER_GERNERATION is ON.

// Generated on: Mon Aug 26 14:52:35 2024


#ifndef FRAMETRANSFORMGET_NWC_ROS2_PARAMSPARSER_H
#define FRAMETRANSFORMGET_NWC_ROS2_PARAMSPARSER_H

#include <yarp/os/Searchable.h>
#include <yarp/dev/IDeviceDriverParams.h>
#include <string>
#include <cmath>

/**
* This class is the parameters parser for class FrameTransformGet_nwc_ros2.
*
* These are the used parameters:
* | Group name | Parameter name | Type | Units | Default Value | Required | Description | Notes |
* |:----------:|:----------------:|:------:|:-------:|:-------------:|:--------:|:-----------------------------------------------------------------:|:-----:|
* | GENERAL | refresh_interval | double | seconds | 0.1 | 0 | The time interval outside which timed ft will be deleted | - |
* | ROS2 | ft_node | string | - | tfNodeGet | 0 | The name of the ROS2 node | - |
* | ROS2 | ft_topic | string | - | /tf | 0 | The name of the ROS2 topic from which fts will be received | - |
* | ROS2 | ft_topic_static | string | - | /tf_static | 0 | The name of the ROS2 topic from which static fts will be received | - |
*
* The device can be launched by yarpdev using one of the following examples (with and without all optional parameters):
* \code{.unparsed}
* yarpdev --device frameTransformGet_nwc_ros2 --GENERAL::refresh_interval 0.1 --ROS2::ft_node tfNodeGet --ROS2::ft_topic /tf --ROS2::ft_topic_static /tf_static
* \endcode
*
* \code{.unparsed}
* yarpdev --device frameTransformGet_nwc_ros2
* \endcode
*
*/

class FrameTransformGet_nwc_ros2_ParamsParser : public yarp::dev::IDeviceDriverParams
{
public:
FrameTransformGet_nwc_ros2_ParamsParser();
~FrameTransformGet_nwc_ros2_ParamsParser() override = default;

public:
const std::string m_device_classname = {"FrameTransformGet_nwc_ros2"};
const std::string m_device_name = {"frameTransformGet_nwc_ros2"};
bool m_parser_is_strict = false;
struct parser_version_type
{
int major = 1;
int minor = 0;
};
const parser_version_type m_parser_version = {};

const std::string m_GENERAL_refresh_interval_defaultValue = {"0.1"};
const std::string m_ROS2_ft_node_defaultValue = {"tfNodeGet"};
const std::string m_ROS2_ft_topic_defaultValue = {"/tf"};
const std::string m_ROS2_ft_topic_static_defaultValue = {"/tf_static"};

double m_GENERAL_refresh_interval = {0.1};
std::string m_ROS2_ft_node = {"tfNodeGet"};
std::string m_ROS2_ft_topic = {"/tf"};
std::string m_ROS2_ft_topic_static = {"/tf_static"};

bool parseParams(const yarp::os::Searchable & config) override;
std::string getDeviceClassName() const override { return m_device_classname; }
std::string getDeviceName() const override { return m_device_name; }
std::string getDocumentationOfDeviceParams() const override;
std::vector<std::string> getListOfParams() const override;
};

#endif
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
| GENERAL | refresh_interval | double | seconds | 0.1 | No | The time interval outside which timed ft will be deleted |
| ROS2 | ft_node | string | - | tfNodeGet | No | The name of the ROS2 node |
| ROS2 | ft_topic | string | - | /tf | No | The name of the ROS2 topic from which fts will be received |
| ROS2 | ft_topic_static | string | - | /tf_static | No | The name of the ROS2 topic from which static fts will be received |
Original file line number Diff line number Diff line change
Expand Up @@ -25,39 +25,17 @@ bool FrameTransformGet_nwc_ros2::open(yarp::os::Searchable& config)
yCError(FRAMETRANSFORGETNWCROS2,"Error! YARP Network is not initialized");
return false;
}
parseParams(config);

bool okGeneral = config.check("GENERAL");
if(okGeneral)
{
yarp::os::Searchable& general_config = config.findGroup("GENERAL");
if (general_config.check("refresh_interval")) {m_refreshInterval = general_config.find("refresh_interval").asFloat64();}
}

m_ftContainer.m_timeout = m_refreshInterval;

//ROS2 configuration
if (config.check("ROS2"))
{
yCInfo(FRAMETRANSFORGETNWCROS2, "Configuring ROS2 params");
Bottle ROS2_config = config.findGroup("ROS2");
if(ROS2_config.check("ft_node")) m_ftNodeName = ROS2_config.find("ft_node").asString();
if(ROS2_config.check("ft_topic")) m_ftTopic = ROS2_config.find("ft_topic").asString();
if(ROS2_config.check("ft_topic_static")) m_ftTopicStatic = ROS2_config.find("ft_topic_static").asString();
}
else
{
//no ROS2 options
yCWarning(FRAMETRANSFORGETNWCROS2) << "ROS2 Group not configured";
}

m_node = NodeCreator::createNode(m_ftNodeName);
m_subscriptionFtTimed = m_node->create_subscription<tf2_msgs::msg::TFMessage>(m_ftTopic, 10,
m_ftContainer.m_timeout = m_GENERAL_refresh_interval;
m_node = NodeCreator::createNode(m_ROS2_ft_node);
m_subscriptionFtTimed = m_node->create_subscription<tf2_msgs::msg::TFMessage>(m_ROS2_ft_topic, 10,
std::bind(&FrameTransformGet_nwc_ros2::frameTransformTimedGet_callback,
this, _1));

rclcpp::QoS qos(10);
qos = qos.transient_local(); // This line and the previous are needed to reestablish the "latched" behaviour for the subscriptio
m_subscriptionFtStatic = m_node->create_subscription<tf2_msgs::msg::TFMessage>(m_ftTopicStatic, qos,
m_subscriptionFtStatic = m_node->create_subscription<tf2_msgs::msg::TFMessage>(m_ROS2_ft_topic_static, qos,
std::bind(&FrameTransformGet_nwc_ros2::frameTransformStaticGet_callback,
this, _1));

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
#include <Ros2Utils.h>
#include <mutex>
#include <map>
#include "FrameTransformGet_nwc_ros2_ParamsParser.h"

#define ROS2NODENAME "tfNodeGet"
#define ROS2TOPICNAME_TF "/tf"
Expand All @@ -38,16 +39,8 @@
*
* \section FrameTransformGet_nwc_ros2_device_parameters Parameters
*
* Parameters required by this device are:
* | Parameter name | SubParameter | Type | Units | Default Value | Required | Description ------- |
* |:--------------:|:--------------------:|:-------:|:--------------:|:---------------------:|:-----------: |:-----------------------------------------------------------------:|
* | GENERAL | - | group | - | - | No | |
* | - | refresh_interval | double | seconds | 0.1 | No | The time interval outside which timed ft will be deleted |
* | ROS2 | - | group | - | - | No | |
* | - | ft_node | string | - | /tfNodeGet | No | The name of the ROS2 node |
* | - | ft_topic | string | - | /tf | No | The name of the ROS2 topic from which fts will be received |
* | - | ft_topic_static | string | - | /tf_static | No | The name of the ROS2 topic from which static fts will be received |
* Parameters required by this device are shown in class: FrameTransformGet_nwc_ros2_ParamsParser
*
* **N.B.** pay attention to the difference between **tf** and **ft**
*
* \section FrameTransformGet_nwc_ros2_device_example Example of configuration file using .ini format.
Expand All @@ -67,7 +60,8 @@

class FrameTransformGet_nwc_ros2 :
public yarp::dev::DeviceDriver,
public yarp::dev::IFrameTransformStorageGet
public yarp::dev::IFrameTransformStorageGet,
FrameTransformGet_nwc_ros2_ParamsParser
{
public:
~FrameTransformGet_nwc_ros2()=default;
Expand All @@ -93,10 +87,6 @@ class FrameTransformGet_nwc_ros2 :

private:
mutable std::mutex m_trf_mutex;
std::string m_ftNodeName{ROS2NODENAME};
std::string m_ftTopic{ROS2TOPICNAME_TF};
std::string m_ftTopicStatic{ROS2TOPICNAME_TF_STATIC};
double m_refreshInterval{0.1};
rclcpp::Subscription<tf2_msgs::msg::TFMessage>::SharedPtr m_subscriptionFtTimed;
rclcpp::Subscription<tf2_msgs::msg::TFMessage>::SharedPtr m_subscriptionFtStatic;
rclcpp::Node::SharedPtr m_node;
Expand Down

0 comments on commit fdb6f33

Please sign in to comment.