-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add methods to get list of names of supported parameters for each solver #18
Conversation
Looks good to me. The only remark, would be not to throw errors in case a parameter is not found, as future versions of the solvers might add parameters that are not yet listed as supported |
Sorry, it is not clear to me how this is related to the current PR. Is this suggesting a change here or is a general remark? |
Not directly, but since the list of parameters has been specified explicitly, I thought to mention it anyhow. For example, I noticed the pattern in the test qpsolvers-eigen/tests/QPTest.cpp Line 44 in 7059f5c
|
Yes, that was just a way to check that the vector did not contained something that was not a parameter. I thought |
This permits to get all the parameters supported by a solver, prerequisite for #8 .