Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

test(packages): switch to RTL and use React 18 #166

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Conversation

JAdshead
Copy link
Contributor

Description

updated React version used by tests to React 18.
Removed enzyme as no longer compatible and replaced with React Testing library.
Removed react-test-renderer to use consistent rendering methods for testing.

Motivation and Context

Test were running with React 16.
To ensure compatibility with react 18 updated tests to use react 18

How Has This Been Tested?

Test suite.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • My changes are in sync with the code style of this project.
  • There aren't any other open Pull Requests for the same issue/update.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • This change impacts caching for client browsers.
  • This change adds additional environment variable requirements for Holocron users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using Holocron?

@JAdshead JAdshead requested a review from a team January 30, 2024 21:50
@JAdshead JAdshead merged commit 8320a76 into next Jan 31, 2024
3 checks passed
@JAdshead JAdshead deleted the test/react-18 branch January 31, 2024 16:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants