Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

fix(externals): use browser and node integrity values #162

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

JAdshead
Copy link
Contributor

@JAdshead JAdshead commented Nov 7, 2023

Description

Motivation and Context

Use separate browser and node integrity values for loading fallback externals.
Prevent modules from being loaded when external fallbacks are required and missing integrity values.

How Has This Been Tested?

Locally using packed holocron installed into one app with local modules requiring externals

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • My changes are in sync with the code style of this project.
  • There aren't any other open Pull Requests for the same issue/update.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • This change impacts caching for client browsers.
  • This change adds additional environment variable requirements for Holocron users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using Holocron?

@JAdshead JAdshead requested a review from a team November 7, 2023 22:16
@JAdshead JAdshead merged commit 5a836b9 into main Nov 8, 2023
6 checks passed
@JAdshead JAdshead deleted the feat/ensure-integrity branch November 8, 2023 15:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants