Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

feat(compose): add console error #148

Conversation

drewcur
Copy link
Contributor

@drewcur drewcur commented Aug 9, 2023

Adding console.error for matching visibility as given by holocronModule.

Description

Adding this console.error will help add visibility to errors coming out of loadModuleData when performed by composeModules. This will help debugging overall.

Motivation and Context

The error is captured and returned, but otherwise is treated silently. With the console.error I can see this occur on both server and client.

How Has This Been Tested?

Unit tested only.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • My changes are in sync with the code style of this project.
  • There aren't any other open Pull Requests for the same issue/update.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • This change impacts caching for client browsers.
  • This change adds additional environment variable requirements for Holocron users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using Holocron?

None.

Adding console.error for matching visibility as given by holocronModule.
@Matthew-Mallimo Matthew-Mallimo merged commit d9977d7 into americanexpress:main Aug 11, 2023
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants