Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

Commit

Permalink
fix(holocron): redux-thunk peer dep breaking
Browse files Browse the repository at this point in the history
  • Loading branch information
JAdshead committed Feb 22, 2024
1 parent 3488f50 commit 753a366
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 9 deletions.
4 changes: 2 additions & 2 deletions packages/holocron/__tests__/holocronModule.spec.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
/* eslint-disable react/prop-types, import/no-extraneous-dependencies -- disable for tests */
import React from 'react';
import { createStore, applyMiddleware } from 'redux';
import { withExtraArgument, thunk } from 'redux-thunk';
import thunk from 'redux-thunk';
import { combineReducers as immutableCombineReducers } from 'redux-immutable';
import { Provider, connect } from 'react-redux';
import { fromJS } from 'immutable';
Expand Down Expand Up @@ -399,7 +399,7 @@ describe('holocronModule', () => {
})(TestComponent);
const mockStore = createStore(
(state) => state,
applyMiddleware(withExtraArgument({ fetchClient: jest.fn() }))
applyMiddleware(thunk.withExtraArgument({ fetchClient: jest.fn() }))
);

render(
Expand Down
2 changes: 1 addition & 1 deletion packages/holocron/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"immutable": "^4.0.0-rc.12",
"prop-types": "^15.5.10",
"redux-immutable": "^4.0.0",
"redux-thunk": "^3.1.0",
"redux-thunk": "^2.1.0",
"require-from-string": "^1.2.1",
"reselect": "^4.0.0",
"semver": "^7.3.8",
Expand Down
4 changes: 2 additions & 2 deletions packages/holocron/src/createHolocronStore.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

import { createStore, compose } from 'redux';
import immutableCombineReducers from '@americanexpress/vitruvius/immutable';
import { withExtraArgument } from 'redux-thunk';
import thunk from 'redux-thunk';
import { Map as iMap, Set as iSet, isImmutable } from 'immutable';

import holocronReducer from './ducks/load';
Expand Down Expand Up @@ -116,7 +116,7 @@ const holocronEnhancer = (localsForBuildInitialState, extraThunkArguments = {})
getState: store.getState,
dispatch: (action) => dispatch(action),
};
dispatch = withExtraArgument({
dispatch = thunk.withExtraArgument({
...extraThunkArguments,
rebuildReducer,
modules: store.modules,
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -9559,10 +9559,10 @@ redux-immutable@^4.0.0:
resolved "https://registry.yarnpkg.com/redux-immutable/-/redux-immutable-4.0.0.tgz#3a1a32df66366462b63691f0e1dc35e472bbc9f3"
integrity sha512-SchSn/DWfGb3oAejd+1hhHx01xUoxY+V7TeK0BKqpkLKiQPVFf7DYzEaKmrEVxsWxielKfSK9/Xq66YyxgR1cg==

redux-thunk@^3.1.0:
version "3.1.0"
resolved "https://registry.yarnpkg.com/redux-thunk/-/redux-thunk-3.1.0.tgz#94aa6e04977c30e14e892eae84978c1af6058ff3"
integrity sha512-NW2r5T6ksUKXCabzhL9z+h206HQw/NJkcLm1GPImRQ8IzfXwRGqjVhKJGauHirT0DAuyy6hjdnMZaRoAcy0Klw==
redux-thunk@^2.1.0:
version "2.4.2"
resolved "https://registry.yarnpkg.com/redux-thunk/-/redux-thunk-2.4.2.tgz#b9d05d11994b99f7a91ea223e8b04cf0afa5ef3b"
integrity sha512-+P3TjtnP0k/FEjcBL5FZpoovtvrTNT/UXd4/sluaSyrURlSlhLSzEdfsTBW7WsKB6yPvgd7q/iZPICFjW4o57Q==

redux@^4.0.0, redux@^4.0.4:
version "4.2.1"
Expand Down

0 comments on commit 753a366

Please sign in to comment.