Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data-provider] Decouple data retrieval from rendering #221

Merged
merged 1 commit into from
May 31, 2022

Conversation

JorgenEvens
Copy link
Member

@JorgenEvens JorgenEvens commented Jan 2, 2021

@JorgenEvens JorgenEvens self-assigned this Jan 2, 2021
maxWidth: '100%',
width: size.str,
height: size.str,
borderRadius: (round === true ? '100%' : round)
Copy link

@NiharR27 NiharR27 May 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JorgenEvens - won't this pass false to borderRadius if round is false?

because borderRadius can't be a boolean i think

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you pass false here, borderRadius will simply be removed from the final stylesheet so this doesn't pose a problem

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concerns handled by #242

@NiharR27
Copy link

NiharR27 commented May 30, 2022

Also, can this be merged :) please @JorgenEvens

@JorgenEvens JorgenEvens merged commit 6146507 into master May 31, 2022
@JorgenEvens JorgenEvens deleted the feature/decouple-rendering branch May 31, 2022 14:34
@JorgenEvens JorgenEvens added this to the 5.0.0 milestone May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants