Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add trailing_commas to dump/dumps #372

Merged
merged 6 commits into from
Oct 21, 2024

Commits on Oct 9, 2024

  1. feat: Add trailing_commas to dump/dumps

    Add an optional boolean argument `trailing_commas` to the `dump`
    and `dumps` methods in `simpleion`. Default: False.
    
    When `trailing_commas=True`, and when `indent` is not `None`, this
    causes `dump[s]` to include a comma on the last item in a container.
    
    **Note:** Since the C module already **does not support pretty
    printing**, this flag does nothing when using the C module.
    Stephen Jacob committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    11e449b View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. fix: Fix test errors for trailing_commas test additions

    Stephen Jacob committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    d753ba1 View commit details
    Browse the repository at this point in the history
  2. fix: trailing_commas: fix tests & only when indent set

    Make the `trailing_commas` flag do what it says: Only apply when pretty
    printing (`indent is not None`).
    
    Fix all remaining `test_simpleion.py` failures.
    Stephen Jacob committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    b124edc View commit details
    Browse the repository at this point in the history
  3. fix: Remove accidentally left-in debugging-aid comment

    Stephen Jacob committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    1d2f00d View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. Configuration menu
    Copy the full SHA
    4a88648 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b2f91a9 View commit details
    Browse the repository at this point in the history