Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated test_atom_arrangement.py #986

Closed
wants to merge 1 commit into from

Conversation

AbdullahKazi500
Copy link

Issue #, if available:
fixes #969
Description of changes:
test_add_chaining: Verifies the add method supports method chaining.
test_iteration: Ensures iteration over AtomArrangement returns the correct coordinates.
test_coordinate_list: Validates the coordinate_list method returns the correct coordinate lists.
test_discretize: Parametrized test that checks the discretize method for various resolutions.
test_invalid_discretization_properties: Expects a DiscretizationError when invalid properties are provided.
Testing done:
added test

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

test_add_chaining: Verifies the add method supports method chaining.
test_iteration: Ensures iteration over AtomArrangement returns the correct coordinates.
test_coordinate_list: Validates the coordinate_list method returns the correct coordinate lists.
test_discretize: Parametrized test that checks the discretize method for various resolutions.
test_invalid_discretization_properties: Expects a DiscretizationError when invalid properties are provided.
@peterkomar-aws
Copy link
Contributor

Please consolidate the work to this PR: #989

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Factory methods for AHS AtomArrangments
2 participants