Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove parametric calibration workaround #915

Draft
wants to merge 66 commits into
base: main
Choose a base branch
from

Conversation

jcjaskula-aws
Copy link
Contributor

Issue #, if available:
When we started vending calibrations, we introduced a workaround to avoid providing parametric calibrations with quantum circuits. For example, the following circuit:

OPENQASM 3.0;
defcal rx(theta) $0 {
 ...
}
rx(0.2) $0;

would be modified to

OPENQASM 3.0;
defcal rx(0.2) $0 {
 ...
}
rx(0.2) $0;

Description of changes:
The present PR intends to keep track of this workaround and provide the right behavior.

Testing done:
Unit tests added. As the workaround has been implemented due to a limitation of the service, we should probably add integ tests as well.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

jcjaskula-aws and others added 27 commits December 19, 2023 16:34
* validate out all gphase circuits

* update docstring

* consider ctrl @ gphase

* group error cases
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (661529a) to head (9ea4a07).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #915   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          132       132           
  Lines         8823      8803   -20     
  Branches      1986      1978    -8     
=========================================
- Hits          8823      8803   -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants