Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infra: limit installs for dependent-tests.yml #792

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

infra: limit installs for dependent-tests.yml #792

Changes from 5 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
a223e0a
Update dependent-tests.yml
AbeCoull Nov 9, 2023
fd041b4
Update dependent-tests.yml
AbeCoull Nov 14, 2023
b55b301
Update dependent-tests.yml
AbeCoull Nov 14, 2023
a2ca6cc
Update dependent-tests.yml
AbeCoull Nov 14, 2023
15e42b2
Merge branch 'main' into math411-patch-4
AbeCoull Nov 16, 2023
4aa606c
ensure branch is set to the PR branch
AbeCoull Nov 16, 2023
e217212
add args
AbeCoull Nov 16, 2023
bb4d0ad
tox
AbeCoull Nov 16, 2023
2c1ed5e
Merge branch 'main' into math411-patch-4
AbeCoull Nov 17, 2023
4ce74ac
Merge branch 'main' into math411-patch-4
AbeCoull Nov 24, 2023
f33ede5
Update update_dependency.py
AbeCoull Nov 24, 2023
a70bded
Merge branch 'main' into math411-patch-4
AbeCoull Dec 6, 2023
403ec89
Merge branch 'main' into math411-patch-4
AbeCoull Dec 21, 2023
43599de
Merge branch 'main' into math411-patch-4
AbeCoull Jan 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions .github/workflows/dependent-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,16 +29,13 @@ jobs:
- name: Install dependencies
run: |
pip install --upgrade pip
pip install --upgrade git+https://github.com/aws/amazon-braket-schemas-python.git@main
pip install --upgrade git+https://github.com/aws/amazon-braket-default-simulator-python.git@main
pip install -e .
cd ..
git clone https://github.com/aws/${{ matrix.dependent }}.git
cd ${{ matrix.dependent }}
# Update the amazon-braket-sdk dependency to reference the current commit
python ${GITHUB_WORKSPACE}/.github/scripts/update_dependency.py
pip install -e .[test]
pip install tox
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you validate if this causes the tests to reference the SDK mainline instead of the current commit?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am unsure of the behavior when you left this comment so I added a deterministic change to the tox file to ensure the setup uses the working branch for the PR.

From the test logs:

unit-tests: install_deps> python -I -m pip install git+https://github.com/amazon-braket/amazon-braket-sdk-python.git@math411-patch-4

- name: Run unit tests
run: |
cd ../${{ matrix.dependent }}
pytest
tox -e unit-tests