Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update devices enum integ test #654

Merged
merged 6 commits into from
Aug 2, 2023
Merged

test: update devices enum integ test #654

merged 6 commits into from
Aug 2, 2023

Conversation

ajberdy
Copy link
Contributor

@ajberdy ajberdy commented Aug 1, 2023

Issue #, if available:

Description of changes:

update condition to filter out non-enum attributes of Devices

Testing done:

regression on python < 3.11

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ajberdy ajberdy requested a review from a team as a code owner August 1, 2023 23:39
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #654 (e518437) into main (e7281e9) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #654   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          121       121           
  Lines         7885      7885           
  Branches      1751      1751           
=========================================
  Hits          7885      7885           

krneta
krneta previously approved these changes Aug 2, 2023
@ajberdy ajberdy merged commit 6187226 into main Aug 2, 2023
28 checks passed
@ajberdy ajberdy deleted the integ-update branch August 2, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants