Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add off_center to erf_square #1023

Merged
merged 2 commits into from
Aug 23, 2024
Merged

Conversation

yitchen-tim
Copy link
Contributor

Description of changes:
Add an off_center parameter to allow offsetting the smoothed square toward left or right in a erf_square waveform.

Testing done:
tox

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f87be27) to head (647d206).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1023   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          135       135           
  Lines         9035      9036    +1     
  Branches      2030      2030           
=========================================
+ Hits          9035      9036    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yitchen-tim yitchen-tim marked this pull request as ready for review August 22, 2024 13:47
@yitchen-tim yitchen-tim requested a review from a team as a code owner August 22, 2024 13:47
@yitchen-tim yitchen-tim merged commit a79dccc into main Aug 23, 2024
26 checks passed
@yitchen-tim yitchen-tim deleted the yitchen/erf-square-off-center branch August 23, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants